From: Juergen Gross <jgross@suse.com>
To: David Woodhouse <dwmw2@infradead.org>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel <xen-devel@lists.xenproject.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] xen: Allow platform PCI interrupt to be shared
Date: Mon, 13 Feb 2023 09:18:59 +0100 [thread overview]
Message-ID: <a045836e-25c1-3d9b-b3fa-a212f0432cda@suse.com> (raw)
In-Reply-To: <f9a29a68d05668a3636dd09acd94d970269eaec6.camel@infradead.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1009 bytes --]
On 18.01.23 13:22, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> When we don't use the per-CPU vector callback, we ask Xen to deliver event
> channel interrupts as INTx on the PCI platform device. As such, it can be
> shared with INTx on other PCI devices.
>
> Set IRQF_SHARED, and make it return IRQ_HANDLED or IRQ_NONE according to
> whether the evtchn_upcall_pending flag was actually set. Now I can share
> the interrupt:
>
> 11: 82 0 IO-APIC 11-fasteoi xen-platform-pci, ens4
>
> Drop the IRQF_TRIGGER_RISING. It has no effect when the IRQ is shared,
> and besides, the only effect it was having even beforehand was to trigger
> a debug message in both I/OAPIC and legacy PIC cases:
>
> [ 0.915441] genirq: No set_type function for IRQ 11 (IO-APIC)
> [ 0.951939] genirq: No set_type function for IRQ 11 (XT-PIC)
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Pushed to: xen/tip.git for-linus-6.3
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2023-02-13 8:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 12:22 David Woodhouse
2023-01-18 13:53 ` Andrew Cooper
2023-01-18 14:06 ` David Woodhouse
2023-01-18 14:22 ` Andrew Cooper
2023-01-18 14:26 ` David Woodhouse
2023-01-18 14:39 ` Andrew Cooper
2023-01-18 14:43 ` David Woodhouse
2023-01-20 7:20 ` Juergen Gross
2023-02-13 8:18 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a045836e-25c1-3d9b-b3fa-a212f0432cda@suse.com \
--to=jgross@suse.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@xen.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®