From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: David Woodhouse <dwmw2@infradead.org>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel <xen-devel@lists.xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH] xen: Allow platform PCI interrupt to be shared
Date: Wed, 18 Jan 2023 13:53:28 +0000 [thread overview]
Message-ID: <e0b75988-bee6-e0c7-0dda-86e1e973ba74@citrix.com> (raw)
In-Reply-To: <f9a29a68d05668a3636dd09acd94d970269eaec6.camel@infradead.org>
On 18/01/2023 12:22 pm, David Woodhouse wrote:
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
> What does xen_evtchn_do_upcall() exist for? Can we delete it? I don't
> see it being called anywhere.
Seems the caller was dropped by
cb09ea2924cbf1a42da59bd30a59cc1836240bcb, but the CONFIG_PVHVM looks
bogus because the precondition to setting it up was being in a Xen HVM
guest, and the guest is taking evtchns by vector either way.
PV guests use the entrypoint called exc_xen_hypervisor_callback which
really ought to gain a PV in its name somewhere. Also the comments look
distinctly suspect.
Some tidying in this area would be valuable.
~Andrew
next prev parent reply other threads:[~2023-01-18 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 12:22 David Woodhouse
2023-01-18 13:53 ` Andrew Cooper [this message]
2023-01-18 14:06 ` David Woodhouse
2023-01-18 14:22 ` Andrew Cooper
2023-01-18 14:26 ` David Woodhouse
2023-01-18 14:39 ` Andrew Cooper
2023-01-18 14:43 ` David Woodhouse
2023-01-20 7:20 ` Juergen Gross
2023-02-13 8:18 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b75988-bee6-e0c7-0dda-86e1e973ba74@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=dwmw2@infradead.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@xen.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®