Re: [PATCH v2] media: qcom: iris: initialize OPP pointer at declaration

[Bryan O'Donoghue <bryan.odonoghue@linaro.org>]

On 08/06/2026 13:05, Hungyu Lin wrote:
> Initialize the managed OPP pointer at declaration rather than
> assigning it in a separate statement.
> 
> This avoids a checkpatch warning about a potentially uninitialized
> managed pointer.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> Changes in v2:
> - Initialize the managed pointer directly at declaration as suggested
>    by Dmitry Baryshkov.
> 
>   drivers/media/platform/qcom/iris/iris_resources.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c
> index 773f6548370a..fd643cbff8d2 100644
> --- a/drivers/media/platform/qcom/iris/iris_resources.c
> +++ b/drivers/media/platform/qcom/iris/iris_resources.c
> @@ -61,9 +61,9 @@ int iris_unset_icc_bw(struct iris_core *core)
> 
>   int iris_opp_set_rate(struct device *dev, unsigned long freq)
>   {
> -	struct dev_pm_opp *opp __free(put_opp);
> +	struct dev_pm_opp *opp __free(put_opp) =
> +		devfreq_recommended_opp(dev, &freq, 0);
> 
> -	opp = devfreq_recommended_opp(dev, &freq, 0);
>   	if (IS_ERR(opp))
>   		return PTR_ERR(opp);
> 
> --
> 2.34.1
> 
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>