From: Tom Lendacky <thomas.lendacky@amd.com>
To: Nikunj A Dadhania <nikunj@amd.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Cc: bp@alien8.de, dionnaglaze@google.com, pgonda@google.com,
seanjc@google.com, pbonzini@redhat.com
Subject: Re: [PATCH v3 01/14] virt: sev-guest: Use AES GCM crypto library
Date: Tue, 1 Aug 2023 10:32:28 -0500 [thread overview]
Message-ID: <a056ff8f-1dab-72b4-133f-a6578c7216ad@amd.com> (raw)
In-Reply-To: <20230722111909.15166-2-nikunj@amd.com>
On 7/22/23 06:18, Nikunj A Dadhania wrote:
> The sev-guest driver encryption code uses Crypto API for SNP guest
> messaging to interact with AMD Security processor. For enabling SecureTSC,
> SEV-SNP guests need to send a TSC_INFO request guest message before the
> smpboot phase starts. Details from the TSC_INFO response will be used to
> program the VMSA before the secondary CPUs are brought up. The Crypto API
> is not available this early in the boot phase.
>
> In preparation of moving the encryption code out of sev-guest driver to
> support SecureTSC and make reviewing the diff easier, start using AES GCM
> library implementation instead of Crypto API.
>
> Link: https://lore.kernel.org/all/20221103192259.2229-1-ardb@kernel.org
> CC: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/virt/coco/sev-guest/Kconfig | 3 +-
> drivers/virt/coco/sev-guest/sev-guest.c | 172 +++++++-----------------
> drivers/virt/coco/sev-guest/sev-guest.h | 3 +
> 3 files changed, 53 insertions(+), 125 deletions(-)
>
next prev parent reply other threads:[~2023-08-01 15:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 11:18 [PATCH v3 00/14] Add Secure TSC support for SNP guests Nikunj A Dadhania
2023-07-22 11:18 ` [PATCH v3 01/14] virt: sev-guest: Use AES GCM crypto library Nikunj A Dadhania
2023-08-01 15:32 ` Tom Lendacky [this message]
2023-07-22 11:18 ` [PATCH v3 02/14] virt: sev-guest: Move mutex to SNP guest device structure Nikunj A Dadhania
2023-07-22 11:18 ` [PATCH v3 03/14] virt: sev-guest: Replace pr_debug with dev_dbg Nikunj A Dadhania
2023-08-01 15:34 ` Tom Lendacky
2023-08-02 4:08 ` Nikunj A. Dadhania
2023-07-22 11:18 ` [PATCH v3 04/14] virt: sev-guest: Add SNP guest request structure Nikunj A Dadhania
2023-08-01 15:49 ` Tom Lendacky
2023-08-02 4:10 ` Nikunj A. Dadhania
2023-07-22 11:19 ` [PATCH v3 05/14] virt: sev-guest: Add vmpck_id to snp_guest_dev struct Nikunj A Dadhania
2023-08-01 16:30 ` Tom Lendacky
2023-08-02 4:12 ` Nikunj A. Dadhania
2023-08-02 16:55 ` Tom Lendacky
2023-08-03 5:02 ` Nikunj A. Dadhania
2023-07-22 11:19 ` [PATCH v3 06/14] x86/sev: Cache the secrets page address Nikunj A Dadhania
2023-08-01 16:34 ` Tom Lendacky
2023-07-22 11:19 ` [PATCH v3 07/14] x86/sev: Move and reorganize sev guest request api Nikunj A Dadhania
2023-07-22 11:19 ` [PATCH v3 08/14] x86/mm: Add generic guest initialization hook Nikunj A Dadhania
2023-07-22 11:19 ` [PATCH v3 09/14] x86/sev: Add Secure TSC support for SNP guests Nikunj A Dadhania
2023-07-22 11:19 ` [PATCH v3 10/14] x86/sev: Change TSC MSR behavior for Secure TSC enabled guests Nikunj A Dadhania
2023-07-22 11:19 ` [PATCH v3 11/14] x86/sev: Prevent RDTSC/RDTSCP interception " Nikunj A Dadhania
2023-07-22 11:19 ` [PATCH v3 12/14] x86/kvmclock: Skip kvmclock when Secure TSC is available Nikunj A Dadhania
2023-07-22 11:19 ` [PATCH v3 13/14] x86/tsc: Mark Secure TSC as reliable clocksource Nikunj A Dadhania
2023-07-22 11:19 ` [PATCH v3 14/14] x86/sev: Enable Secure TSC for SNP guests Nikunj A Dadhania
2023-08-01 4:47 ` [PATCH v3 00/14] Add Secure TSC support " Nikunj A. Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a056ff8f-1dab-72b4-133f-a6578c7216ad@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@alien8.de \
--cc=dionnaglaze@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®