From: Jon Hunter <jonathanh@nvidia.com>
To: Arnd Bergmann <arnd@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Kartik <kkartik@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc/tegra: fix build failure on Tegra241
Date: Tue, 30 Jan 2024 11:01:51 +0000 [thread overview]
Message-ID: <a06713d9-5e29-466c-9eb9-ddb86e2f0677@nvidia.com> (raw)
In-Reply-To: <20240103102654.3779458-1-arnd@kernel.org>
On 03/01/2024 10:26, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> If all the other SoCs are disabled, the driver fails to build:
>
> drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error: 'tegra30_fuse_read' undeclared here (not in a function); did you mean 'tegra_fuse_readl'?
> 684 | .read = tegra30_fuse_read,
> | ^~~~~~~~~~~~~~~~~
> | tegra_fuse_readl
> drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error: 'tegra30_fuse_init' undeclared here (not in a function); did you mean 'tegra_fuse_info'?
> 694 | .init = tegra30_fuse_init,
> | ^~~~~~~~~~~~~~~~~
>
> Fix the list of SoCs using this function to include the newly added one.
>
> Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c b/drivers/soc/tegra/fuse/fuse-tegra30.c
> index 2070d36c510d..eb14e5ff5a0a 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> @@ -38,7 +38,8 @@
> defined(CONFIG_ARCH_TEGRA_210_SOC) || \
> defined(CONFIG_ARCH_TEGRA_186_SOC) || \
> defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> - defined(CONFIG_ARCH_TEGRA_234_SOC)
> + defined(CONFIG_ARCH_TEGRA_234_SOC) || \
> + defined(CONFIG_ARCH_TEGRA_241_SOC)
> static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned int offset)
> {
> if (WARN_ON(!fuse->base))
Thanks for fixing!
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
next prev parent reply other threads:[~2024-01-30 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 10:26 Arnd Bergmann
2024-01-30 11:01 ` Jon Hunter [this message]
2024-01-30 11:45 ` Kartik Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a06713d9-5e29-466c-9eb9-ddb86e2f0677@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=kkartik@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®