mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kartik Rajput <kkartik@nvidia.com>
To: Jonathan Hunter <jonathanh@nvidia.com>,
	"arnd@kernel.org" <arnd@kernel.org>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] soc/tegra: fix build failure  on Tegra241
Date: Tue, 30 Jan 2024 11:45:15 +0000	[thread overview]
Message-ID: <a0c534cc7a58034aa15f937a26525887bcd323be.camel@nvidia.com> (raw)
In-Reply-To: <20240103102654.3779458-1-arnd@kernel.org>

On Wed, 2024-01-03 at 11:26 +0100, Arnd Bergmann wrote:
> External email: Use caution opening links or attachments
> 
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> If all the other SoCs are disabled, the driver fails to build:
> 
> drivers/soc/tegra/fuse/fuse-tegra30.c:684:17: error:
> 'tegra30_fuse_read' undeclared here (not in a function); did you mean
> 'tegra_fuse_readl'?
>   684 |         .read = tegra30_fuse_read,
>       |                 ^~~~~~~~~~~~~~~~~
>       |                 tegra_fuse_readl
> drivers/soc/tegra/fuse/fuse-tegra30.c:694:17: error:
> 'tegra30_fuse_init' undeclared here (not in a function); did you mean
> 'tegra_fuse_info'?
>   694 |         .init = tegra30_fuse_init,
>       |                 ^~~~~~~~~~~~~~~~~
> 
> Fix the list of SoCs using this function to include the newly added
> one.
> 
> Fixes: dee509eb9cd5 ("soc/tegra: fuse: Add support for Tegra241")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra30.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/fuse/fuse-tegra30.c
> b/drivers/soc/tegra/fuse/fuse-tegra30.c
> index 2070d36c510d..eb14e5ff5a0a 100644
> --- a/drivers/soc/tegra/fuse/fuse-tegra30.c
> +++ b/drivers/soc/tegra/fuse/fuse-tegra30.c
> @@ -38,7 +38,8 @@
>      defined(CONFIG_ARCH_TEGRA_210_SOC) || \
>      defined(CONFIG_ARCH_TEGRA_186_SOC) || \
>      defined(CONFIG_ARCH_TEGRA_194_SOC) || \
> -    defined(CONFIG_ARCH_TEGRA_234_SOC)
> +    defined(CONFIG_ARCH_TEGRA_234_SOC) || \
> +    defined(CONFIG_ARCH_TEGRA_241_SOC)
>  static u32 tegra30_fuse_read_early(struct tegra_fuse *fuse, unsigned
> int offset)
>  {
>         if (WARN_ON(!fuse->base))
> --
> 2.39.2
> 

Thanks Arnd!

Reviewed-by: Kartik <kkartik@nvidia.com>

      parent reply	other threads:[~2024-01-30 11:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 10:26 Arnd Bergmann
2024-01-30 11:01 ` Jon Hunter
2024-01-30 11:45 ` Kartik Rajput [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0c534cc7a58034aa15f937a26525887bcd323be.camel@nvidia.com \
    --to=kkartik@nvidia.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®