* [PATCH][next] drm/amd/display: Fix spelling mistake of function name
@ 2021-01-20 9:26 Colin King
2021-01-20 14:46 ` Harry Wentland
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2021-01-20 9:26 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Rodrigo Siqueira, amd-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are two spelling mistakes of the function name, fix this
by using __func__ instead of a hard coded name string.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index c16af3983fdb..91d4130cd2cb 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
- DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
+ DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
return true;
device_tag_fail:
link->link_enc->funcs->destroy(&link->link_enc);
@@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
link->hpd_gpio = NULL;
}
- DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
+ DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
kfree(info);
return false;
--
2.29.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name
2021-01-20 9:26 [PATCH][next] drm/amd/display: Fix spelling mistake of function name Colin King
@ 2021-01-20 14:46 ` Harry Wentland
2021-01-20 21:58 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2021-01-20 14:46 UTC (permalink / raw)
To: Colin King, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Rodrigo Siqueira, amd-gfx,
dri-devel
Cc: kernel-janitors, linux-kernel
On 2021-01-20 4:26 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> There are two spelling mistakes of the function name, fix this
> by using __func__ instead of a hard coded name string.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index c16af3983fdb..91d4130cd2cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
>
> link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>
> - DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> + DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
> return true;
> device_tag_fail:
> link->link_enc->funcs->destroy(&link->link_enc);
> @@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
> link->hpd_gpio = NULL;
> }
>
> - DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> + DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
> kfree(info);
>
> return false;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name
2021-01-20 14:46 ` Harry Wentland
@ 2021-01-20 21:58 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-01-20 21:58 UTC (permalink / raw)
To: Harry Wentland
Cc: Colin King, Leo Li, Alex Deucher, Christian König,
David Airlie, Daniel Vetter, Rodrigo Siqueira, amd-gfx list,
Maling list - DRI developers, kernel-janitors, LKML
Applied. Thanks!
Alex
On Wed, Jan 20, 2021 at 9:46 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2021-01-20 4:26 a.m., Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > There are two spelling mistakes of the function name, fix this
> > by using __func__ instead of a hard coded name string.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> > index c16af3983fdb..91d4130cd2cb 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> > @@ -1602,7 +1602,7 @@ static bool dc_link_construct(struct dc_link *link,
> >
> > link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
> >
> > - DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> > + DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
> > return true;
> > device_tag_fail:
> > link->link_enc->funcs->destroy(&link->link_enc);
> > @@ -1619,7 +1619,7 @@ static bool dc_link_construct(struct dc_link *link,
> > link->hpd_gpio = NULL;
> > }
> >
> > - DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> > + DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
> > kfree(info);
> >
> > return false;
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-20 22:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 9:26 [PATCH][next] drm/amd/display: Fix spelling mistake of function name Colin King
2021-01-20 14:46 ` Harry Wentland
2021-01-20 21:58 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®