mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: "Yunfei Dong" <yunfei.dong@mediatek.com>,
	"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
	"Sebastian Fricke" <sebastian.fricke@collabora.com>,
	"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
	"Nathan Hebert" <nhebert@chromium.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
	Fritz Koenig <frkoenig@chromium.org>,
	 Daniel Vetter <daniel@ffwll.ch>,
	Steve Cho <stevecho@chromium.org>,
	linux-media@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	 Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 11/14] media: mediatek: vcodec: add debug information
Date: Fri, 28 Nov 2025 15:20:31 -0500	[thread overview]
Message-ID: <a08a1f352ded0453f1cf94756e497bf5c8efb9ed.camel@collabora.com> (raw)
In-Reply-To: <20250815085232.30240-12-yunfei.dong@mediatek.com>

[-- Attachment #1: Type: text/plain, Size: 2660 bytes --]

Le vendredi 15 août 2025 à 16:52 +0800, Yunfei Dong a écrit :
> Print hevc/av1 output format and 10bit capture format
> information to debug.
> 
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  .../mediatek/vcodec/common/mtk_vcodec_dbgfs.c | 21 +++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_dbgfs.c b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_dbgfs.c
> index 5ad3797836db..79ccbe13735a 100644
> --- a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_dbgfs.c
> +++ b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_dbgfs.c
> @@ -29,6 +29,14 @@ static void mtk_vdec_dbgfs_get_format_type(struct mtk_vcodec_dec_ctx *ctx, char
>  		curr_len = snprintf(buf + *used, total - *used,
>  				    "\toutput format: vp9 slice\n");
>  		break;
> +	case V4L2_PIX_FMT_HEVC_SLICE:
> +		curr_len = snprintf(buf + *used, total - *used,
> +				    "\toutput format: hevc slice\n");
> +		break;
> +	case V4L2_PIX_FMT_AV1_FRAME:
> +		curr_len = snprintf(buf + *used, total - *used,
> +				    "\toutput format: av1 slice\n");
> +		break;
>  	default:
>  		curr_len = snprintf(buf + *used, total - *used,
>  				    "\tunsupported output format: 0x%x\n",
> @@ -45,6 +53,14 @@ static void mtk_vdec_dbgfs_get_format_type(struct mtk_vcodec_dec_ctx *ctx, char
>  		curr_len = snprintf(buf + *used, total - *used,
>  				    "\tcapture format: MT21C\n");
>  		break;
> +	case V4L2_PIX_FMT_MT2110T:
> +		curr_len = snprintf(buf + *used, total - *used,
> +				    "\tcapture format: MT2110T (10bit tile mode)\n");
> +		break;
> +	case V4L2_PIX_FMT_MT2110R:
> +		curr_len = snprintf(buf + *used, total - *used,
> +				    "\tcapture format: MT2110T (10bit raster mode)\n");
> +		break;
>  	default:
>  		curr_len = snprintf(buf + *used, total - *used,
>  				    "\tunsupported capture format: 0x%x\n",
> @@ -122,9 +138,10 @@ static ssize_t mtk_vdec_dbgfs_read(struct file *filp, char __user *ubuf,
>  
>  		if (dbgfs_index[MTK_VDEC_DBGFS_PICINFO]) {
>  			curr_len = snprintf(buf + used_len, total_len - used_len,
> -					    "\treal(%dx%d)=>align(%dx%d)\n",
> +					    "\treal(%dx%d)=>align(%dx%d) 10bit(%d)\n",
>  					    ctx->picinfo.pic_w, ctx->picinfo.pic_h,
> -					    ctx->picinfo.buf_w, ctx->picinfo.buf_h);
> +					    ctx->picinfo.buf_w, ctx->picinfo.buf_h,
> +					    ctx->is_10bit_bitstream);
>  			used_len += curr_len;
>  		}
>  

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-11-28 20:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15  8:52 [PATCH v2 00/14] media: mediatek: vcodec: support video decoder in mt8196 Yunfei Dong
2025-08-15  8:52 ` [PATCH v2 01/14] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8196 Yunfei Dong
2025-08-19  9:01   ` Krzysztof Kozlowski
2025-08-19  9:05     ` Krzysztof Kozlowski
2025-11-28 19:32   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 02/14] media: mediatek: vcodec: add decoder compatible to support mt8196 Yunfei Dong
2025-11-28 19:34   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 03/14] media: mediatek: vcodec: add driver to support vcp Yunfei Dong
2025-11-28 20:01   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 04/14] media: mediatek: vcodec: add driver to support vcp encoder Yunfei Dong
2025-11-28 20:05   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 05/14] media: mediatek: vcodec: get different firmware ipi id Yunfei Dong
2025-11-28 20:07   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 06/14] media: mediatek: vcodec: get share memory address Yunfei Dong
2025-11-28 20:12   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 07/14] media: mediatek: vcodec: define MT8196 vcodec levels Yunfei Dong
2025-11-28 19:37   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 08/14] media: mediatek: vcodec: support vcp architecture Yunfei Dong
2025-11-28 20:14   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 09/14] media: mediatek: vcodec: support 36bit iova address Yunfei Dong
2025-11-28 20:15   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 10/14] media: mediatek: vcodec: clean xpc status Yunfei Dong
2025-11-28 20:19   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 11/14] media: mediatek: vcodec: add debug information Yunfei Dong
2025-11-28 20:20   ` Nicolas Dufresne [this message]
2025-08-15  8:52 ` [PATCH v2 12/14] media: mediatek: vcodec: send share memory address to vcp Yunfei Dong
2025-11-28 20:22   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 13/14] media: mediatek: decoder: fill av1 buffer size with picinfo Yunfei Dong
2025-11-28 20:23   ` Nicolas Dufresne
2025-08-15  8:52 ` [PATCH v2 14/14] media: mediatek: decoder: support av1 extend vsi Yunfei Dong
2025-11-28 20:26   ` Nicolas Dufresne
2025-11-28 19:30 ` [PATCH v2 00/14] media: mediatek: vcodec: support video decoder in mt8196 Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a08a1f352ded0453f1cf94756e497bf5c8efb9ed.camel@collabora.com \
    --to=nicolas.dufresne@collabora.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=daniel.almeida@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=frkoenig@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=nfraprado@collabora.com \
    --cc=nhebert@chromium.org \
    --cc=sebastian.fricke@collabora.com \
    --cc=stevecho@chromium.org \
    --cc=yunfei.dong@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®