From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: "Yunfei Dong" <yunfei.dong@mediatek.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Sebastian Fricke" <sebastian.fricke@collabora.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Nathan Hebert" <nhebert@chromium.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>,
Steve Cho <stevecho@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 05/14] media: mediatek: vcodec: get different firmware ipi id
Date: Fri, 28 Nov 2025 15:07:41 -0500 [thread overview]
Message-ID: <a89a7288c8e68a93485ad5e2eb42ec02860eea30.camel@collabora.com> (raw)
In-Reply-To: <20250815085232.30240-6-yunfei.dong@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 7008 bytes --]
Hi,
Le vendredi 15 août 2025 à 16:52 +0800, Yunfei Dong a écrit :
> Getting ipi(inter-processor interrupt) id according to firmware
> type and hardware index for different architecture.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> ---
> .../platform/mediatek/vcodec/common/mtk_vcodec_fw.c | 13 +++++++++++++
> .../platform/mediatek/vcodec/common/mtk_vcodec_fw.h | 1 +
> .../vcodec/decoder/vdec/vdec_av1_req_lat_if.c | 4 ++--
> .../vcodec/decoder/vdec/vdec_h264_req_multi_if.c | 4 ++--
> .../vcodec/decoder/vdec/vdec_hevc_req_multi_if.c | 4 ++--
> .../mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c | 4 ++--
> .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 4 ++--
> 7 files changed, 24 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.c b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.c
> index fc547afa4ebf..4ed7639dfa30 100644
> --- a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.c
> +++ b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.c
> @@ -5,6 +5,19 @@
> #include "mtk_vcodec_fw_priv.h"
> #include "mtk_vcodec_fw_vcp.h"
>
> +int mtk_vcodec_fw_get_ipi(enum mtk_vcodec_fw_type type, int hw_id)
> +{
> + switch (type) {
> + case SCP:
> + return hw_id == MTK_VDEC_LAT0 ? SCP_IPI_VDEC_LAT : SCP_IPI_VDEC_CORE;
> + case VCP:
> + return hw_id == MTK_VDEC_LAT0 ? VCP_IPI_LAT_DECODER : VCP_IPI_CORE_DECODER;
> + default:
> + return -EINVAL;
> + }
> +}
> +EXPORT_SYMBOL_GPL(mtk_vcodec_fw_get_ipi);
> +
> struct mtk_vcodec_fw *mtk_vcodec_fw_select(void *priv, enum mtk_vcodec_fw_type type,
> enum mtk_vcodec_fw_use fw_use)
> {
> diff --git a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.h b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.h
> index c1642fb09b42..142e2e87905c 100644
> --- a/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.h
> +++ b/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw.h
> @@ -41,5 +41,6 @@ int mtk_vcodec_fw_ipi_register(struct mtk_vcodec_fw *fw, int id,
> int mtk_vcodec_fw_ipi_send(struct mtk_vcodec_fw *fw, int id,
> void *buf, unsigned int len, unsigned int wait);
> int mtk_vcodec_fw_get_type(struct mtk_vcodec_fw *fw);
> +int mtk_vcodec_fw_get_ipi(enum mtk_vcodec_fw_type type, int hw_id);
>
> #endif /* _MTK_VCODEC_FW_H_ */
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
> index bf21f2467a0f..618064001883 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
> @@ -1886,8 +1886,8 @@ static int vdec_av1_slice_init(struct mtk_vcodec_dec_ctx *ctx)
> return -ENOMEM;
>
> instance->ctx = ctx;
> - instance->vpu.id = SCP_IPI_VDEC_LAT;
> - instance->vpu.core_id = SCP_IPI_VDEC_CORE;
> + instance->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> + instance->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);
Now was a good time to use a local variable.
> instance->vpu.ctx = ctx;
> instance->vpu.codec_type = ctx->current_codec;
>
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> index 5b25e1679b51..50f81f1cb616 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_h264_req_multi_if.c
> @@ -1212,8 +1212,8 @@ static int vdec_h264_slice_init(struct mtk_vcodec_dec_ctx *ctx)
>
> inst->ctx = ctx;
>
> - inst->vpu.id = SCP_IPI_VDEC_LAT;
> - inst->vpu.core_id = SCP_IPI_VDEC_CORE;
> + inst->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> + inst->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);
Same and below.
> inst->vpu.ctx = ctx;
> inst->vpu.codec_type = ctx->current_codec;
> inst->vpu.capture_type = ctx->capture_fourcc;
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> index 2725db882e5b..80fbd0309b9e 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c
> @@ -863,8 +863,8 @@ static int vdec_hevc_slice_init(struct mtk_vcodec_dec_ctx *ctx)
>
> inst->ctx = ctx;
>
> - inst->vpu.id = SCP_IPI_VDEC_LAT;
> - inst->vpu.core_id = SCP_IPI_VDEC_CORE;
> + inst->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> + inst->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);
> inst->vpu.ctx = ctx;
> inst->vpu.codec_type = ctx->current_codec;
> inst->vpu.capture_type = ctx->capture_fourcc;
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> index 232ef3bd246a..764f4d4054c0 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_req_if.c
> @@ -281,8 +281,8 @@ static int vdec_vp8_slice_init(struct mtk_vcodec_dec_ctx *ctx)
>
> inst->ctx = ctx;
>
> - inst->vpu.id = SCP_IPI_VDEC_LAT;
> - inst->vpu.core_id = SCP_IPI_VDEC_CORE;
> + inst->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> + inst->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);
> inst->vpu.ctx = ctx;
> inst->vpu.codec_type = ctx->current_codec;
> inst->vpu.capture_type = ctx->capture_fourcc;
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> index 47c302745c1d..0279f66efdf9 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> @@ -1855,8 +1855,8 @@ static int vdec_vp9_slice_init(struct mtk_vcodec_dec_ctx *ctx)
> return -ENOMEM;
>
> instance->ctx = ctx;
> - instance->vpu.id = SCP_IPI_VDEC_LAT;
> - instance->vpu.core_id = SCP_IPI_VDEC_CORE;
> + instance->vpu.id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_LAT0);
> + instance->vpu.core_id = mtk_vcodec_fw_get_ipi(ctx->dev->fw_handler->type, MTK_VDEC_CORE);
> instance->vpu.ctx = ctx;
> instance->vpu.codec_type = ctx->current_codec;
regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-11-28 20:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 8:52 [PATCH v2 00/14] media: mediatek: vcodec: support video decoder in mt8196 Yunfei Dong
2025-08-15 8:52 ` [PATCH v2 01/14] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8196 Yunfei Dong
2025-08-19 9:01 ` Krzysztof Kozlowski
2025-08-19 9:05 ` Krzysztof Kozlowski
2025-11-28 19:32 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 02/14] media: mediatek: vcodec: add decoder compatible to support mt8196 Yunfei Dong
2025-11-28 19:34 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 03/14] media: mediatek: vcodec: add driver to support vcp Yunfei Dong
2025-11-28 20:01 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 04/14] media: mediatek: vcodec: add driver to support vcp encoder Yunfei Dong
2025-11-28 20:05 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 05/14] media: mediatek: vcodec: get different firmware ipi id Yunfei Dong
2025-11-28 20:07 ` Nicolas Dufresne [this message]
2025-08-15 8:52 ` [PATCH v2 06/14] media: mediatek: vcodec: get share memory address Yunfei Dong
2025-11-28 20:12 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 07/14] media: mediatek: vcodec: define MT8196 vcodec levels Yunfei Dong
2025-11-28 19:37 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 08/14] media: mediatek: vcodec: support vcp architecture Yunfei Dong
2025-11-28 20:14 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 09/14] media: mediatek: vcodec: support 36bit iova address Yunfei Dong
2025-11-28 20:15 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 10/14] media: mediatek: vcodec: clean xpc status Yunfei Dong
2025-11-28 20:19 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 11/14] media: mediatek: vcodec: add debug information Yunfei Dong
2025-11-28 20:20 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 12/14] media: mediatek: vcodec: send share memory address to vcp Yunfei Dong
2025-11-28 20:22 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 13/14] media: mediatek: decoder: fill av1 buffer size with picinfo Yunfei Dong
2025-11-28 20:23 ` Nicolas Dufresne
2025-08-15 8:52 ` [PATCH v2 14/14] media: mediatek: decoder: support av1 extend vsi Yunfei Dong
2025-11-28 20:26 ` Nicolas Dufresne
2025-11-28 19:30 ` [PATCH v2 00/14] media: mediatek: vcodec: support video decoder in mt8196 Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a89a7288c8e68a93485ad5e2eb42ec02860eea30.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel.almeida@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nfraprado@collabora.com \
--cc=nhebert@chromium.org \
--cc=sebastian.fricke@collabora.com \
--cc=stevecho@chromium.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®