From: Adrian Hunter <adrian.hunter@intel.com>
To: "Ng, Adrian Ho Yin" <adrianhoyin.ng@altera.com>,
Frank Li <Frank.li@nxp.com>
Cc: <alexandre.belloni@bootlin.com>, <linux-i3c@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] i3c: dw: Add sysfs support for Device NACK Retry count
Date: Tue, 25 Nov 2025 16:05:53 +0200 [thread overview]
Message-ID: <a09b21bd-84b6-435e-b6e0-fe94c9e62f4a@intel.com> (raw)
In-Reply-To: <f5ff6901-ada5-47ce-822d-11aa35adabc9@altera.com>
On 25/11/2025 05:19, Ng, Adrian Ho Yin wrote:
> On 11/25/2025 1:59 AM, Frank Li wrote:
>
>>> +
>>> + master->dev_nack_retry_cnt = val;
>>> +
>>> + spin_lock_irqsave(&master->devs_lock, flags);
>>
>> I think you'd better to hold i3c_bus_maintenance_lock() lock to make
>> sure not transfer on going.
>>
>> Frank
> Hi Frank
>
> i3c_bus_maintenance_lock is a static function in master.c. So should i update it and expose a public helper to take the maintenance lock or continue using the existing spin lock to protect the DAT updates?
>
> Thank You
> Adrian
Other controllers (e.g. MIPI I3C) support dev_nack_retry_cnt.
Seems to me this should be in master.c anyway, so it can be shared.
next prev parent reply other threads:[~2025-11-25 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 18:00 [PATCH v3 0/3] i3c: dw-i3c: Enable support for dw-i3c controller NACK retry sysfs and DAT restore fix adrianhoyin.ng
2025-11-21 18:00 ` [PATCH v3 1/3] i3c: add sysfs entry for Device NACK Retry count adrianhoyin.ng
2025-11-24 17:47 ` Frank Li
2025-11-21 18:00 ` [PATCH v3 2/3] i3c: dw: Add sysfs support " adrianhoyin.ng
2025-11-24 17:59 ` Frank Li
2025-11-25 3:19 ` Ng, Adrian Ho Yin
2025-11-25 14:05 ` Adrian Hunter [this message]
2025-11-25 17:07 ` Frank Li
2025-11-21 18:00 ` [PATCH v3 3/3] i3c: dw: Preserve DAT entry bits when restoring addresses adrianhoyin.ng
2025-11-24 18:06 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a09b21bd-84b6-435e-b6e0-fe94c9e62f4a@intel.com \
--to=adrian.hunter@intel.com \
--cc=Frank.li@nxp.com \
--cc=adrianhoyin.ng@altera.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®