From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: David Heidelberg <david@ixit.cz>,
Konrad Dybcio <konradybcio@kernel.org>,
Alexander Martinz <amartinz@shift.eco>
Cc: Petr Hodina <petr.hodina@protonmail.com>,
biemster <l.j.beemster@gmail.com>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Rob Herring <robh@kernel.org>,
oe-linux-nfc@lists.linux.dev,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-shift-axolotl: Enable NFC
Date: Wed, 25 Mar 2026 12:20:45 +0100 [thread overview]
Message-ID: <a0da2236-27b3-4491-862a-457a03cb4c5e@oss.qualcomm.com> (raw)
In-Reply-To: <041766dd-422e-40e1-9e5d-c220580871f5@ixit.cz>
On 3/24/26 7:08 PM, David Heidelberg wrote:
>
>
> On 24/03/2026 14:12, Konrad Dybcio wrote:
>> On 3/24/26 12:20 AM, David Heidelberg via B4 Relay wrote:
>>> From: David Heidelberg <david@ixit.cz>
>>>
>>> Definition of the NFC.
>>
>> "meh" commit message
>>
>> [...]
>>
>>> + nfc_enable_default: nfc-enable-default-state {
>>> + pins = "gpio12", "gpio62";
>>> + function = "gpio";
>>> + drive-strength = <2>;
>>> + bias-pull-up;
>>
>> Are you sure about pulling up an active-high pin?
>
> I'm not sure, but downstream does it (and "works for me"). Maybe Alexander would know more details here.
Would changing it to bias-disable also "work for you"?
>
> David
>
>>
>> FWIW TLMM subnodes are best sorted by pin index (although the file
>> currently doesn't really do that) as per dts coding style
>
> I assume when I group the -pins into -state it doesn't apply anymore? As I don't feel having pins relevant to one device / subsystem all over the place is extra clean.
Krzysztof?
Konrad
next prev parent reply other threads:[~2026-03-25 11:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 23:20 [PATCH v2 0/2] NFC support for two Qualcomm SDM845 phones David Heidelberg via B4 Relay
2026-03-23 23:20 ` [PATCH v2 1/2] arm64: dts: qcom: sdm845-oneplus: Enable NFC David Heidelberg via B4 Relay
2026-03-24 7:03 ` Krzysztof Kozlowski
2026-03-24 9:35 ` David Heidelberg
2026-03-24 9:38 ` Krzysztof Kozlowski
2026-03-23 23:20 ` [PATCH v2 2/2] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg via B4 Relay
2026-03-24 13:12 ` Konrad Dybcio
2026-03-24 18:08 ` David Heidelberg
2026-03-25 11:20 ` Konrad Dybcio [this message]
2026-03-25 11:31 ` Krzysztof Kozlowski
2026-03-25 11:39 ` Konrad Dybcio
2026-03-25 20:17 ` David Heidelberg
2026-03-26 11:39 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0da2236-27b3-4491-862a-457a03cb4c5e@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=amartinz@shift.eco \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=l.j.beemster@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
--cc=petr.hodina@protonmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®