mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dusty Mabe <dusty@dustymabe.com>
To: Hannes Reinecke <hare@suse.de>, wq@lst.de
Cc: Minchan Kim <minchan@kernel.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	marmijo@redhat.com
Subject: Re: XFS metadata CRC errors on zram block device on ppc64le architecture
Date: Thu, 3 Aug 2023 17:32:35 -0400	[thread overview]
Message-ID: <a0f05188-d142-82f2-74aa-6c9a6ae2bbc9@dustymabe.com> (raw)
In-Reply-To: <43843fec-f30a-1edc-b428-1d38ddb1050f@dustymabe.com>



On 8/2/23 08:00, Dusty Mabe wrote:
> 
> 
> On 8/2/23 07:03, Hannes Reinecke wrote:
>> On 8/2/23 11:41, Christoph Hellwig wrote:
>>> On Tue, Aug 01, 2023 at 11:31:37PM -0400, Dusty Mabe wrote:
>>>> We ran a kernel bisect and narrowed it down to offending commit af8b04c6:
>>>>
>>>> ```
>>>> [root@ibm-p8-kvm-03-guest-02 linux]# git bisect good
>>>> af8b04c63708fa730c0257084fab91fb2a9cecc4 is the first bad commit
>>>> commit af8b04c63708fa730c0257084fab91fb2a9cecc4
>>>> Author: Christoph Hellwig <hch@lst.de>
>>>> Date:   Tue Apr 11 19:14:46 2023 +0200
>>>>
>>>>      zram: simplify bvec iteration in __zram_make_request
>>>>      
>>>>      bio_for_each_segment synthetize bvecs that never cross page boundaries, so
>>>>      don't duplicate that work in an inner loop.
>>>
>>>> Any ideas on how to fix the problem?
>>>
>>> So the interesting cases are:
>>>
>>>    - ppc64 usually uses 64k page sizes
>>>    - ppc64 is somewhat cache incoherent (compared to say x86)
>>>
>>> Let me think of this a bit more.
>>
>> Would need to be confirmed first that 64k pages really are in use
>> (eg we compile ppc64le with 4k page sizes ...).
>> Dusty?
>> For which page size did you compile your kernel?
> 
> 
> For Fedora the configuration is to enable 64k pages with CONFIG_PPC_64K_PAGES=y
> https://src.fedoraproject.org/rpms/kernel/blob/064c1675a16b4d379b42ab6c3397632ca54ad897/f/kernel-ppc64le-fedora.config#_4791
> 
> I used the same configuration when running the git bisect.

Naive question from my side: would this be a candidate for reverting while we investigate the root cause?

Dusty



  reply	other threads:[~2023-08-03 21:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02  3:31 Dusty Mabe
2023-08-02  9:41 ` Christoph Hellwig
2023-08-02 11:03   ` Hannes Reinecke
2023-08-02 12:00     ` Dusty Mabe
2023-08-03 21:32       ` Dusty Mabe [this message]
2023-08-04  3:25         ` Sergey Senozhatsky
2023-08-04 13:42           ` Christoph Hellwig
2023-08-04 14:20             ` Hannes Reinecke
2023-08-04 16:28           ` Linux regression tracking (Thorsten Leemhuis)
2023-08-04 16:22 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-08-05 12:16   ` Linux regression tracking #update (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0f05188-d142-82f2-74aa-6c9a6ae2bbc9@dustymabe.com \
    --to=dusty@dustymabe.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marmijo@redhat.com \
    --cc=minchan@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=wq@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®