From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Dusty Mabe <dusty@dustymabe.com>,
wq@lst.de, Minchan Kim <minchan@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
marmijo@redhat.com
Subject: Re: XFS metadata CRC errors on zram block device on ppc64le architecture
Date: Fri, 4 Aug 2023 16:20:07 +0200 [thread overview]
Message-ID: <273c9c99-dc2f-2854-bbc1-70b22b5589d8@suse.de> (raw)
In-Reply-To: <20230804134248.GA26611@lst.de>
On 8/4/23 15:42, Christoph Hellwig wrote:
> FYI, I've found an arm64 system with 16k page size support, and while
> I can't reproduce the exact issue, I do see corruption with I/O test
> on zram that don't show on the same system with 4k pages. I'm trying
> to understand the details at the moment.
>
For some reason zram run with a logical block size of 4k:
#define ZRAM_LOGICAL_BLOCK_SHIFT 12
#define ZRAM_LOGICAL_BLOCK_SIZE (1 << ZRAM_LOGICAL_BLOCK_SHIFT)
so we'll have sub-page accesses for larger page sizes.
My bet is that the issue goes away if we set the logical block size to
page size ...
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
next prev parent reply other threads:[~2023-08-04 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 3:31 Dusty Mabe
2023-08-02 9:41 ` Christoph Hellwig
2023-08-02 11:03 ` Hannes Reinecke
2023-08-02 12:00 ` Dusty Mabe
2023-08-03 21:32 ` Dusty Mabe
2023-08-04 3:25 ` Sergey Senozhatsky
2023-08-04 13:42 ` Christoph Hellwig
2023-08-04 14:20 ` Hannes Reinecke [this message]
2023-08-04 16:28 ` Linux regression tracking (Thorsten Leemhuis)
2023-08-04 16:22 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-08-05 12:16 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=273c9c99-dc2f-2854-bbc1-70b22b5589d8@suse.de \
--to=hare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dusty@dustymabe.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marmijo@redhat.com \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=wq@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®