* [PATCH] drm: msm: add null pointer check
@ 2022-03-29 10:34 cgel.zte
2022-03-29 20:55 ` Abhinav Kumar
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-03-29 10:34 UTC (permalink / raw)
To: robdclark
Cc: sean, quic_abhinavk, airlied, daniel, dmitry.baryshkov,
bjorn.andersson, lv.ruyi, greenfoo, linux-arm-msm, dri-devel,
freedreno, linux-kernel, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
kzalloc is a memory allocation function which can return NULL when some
internal memory errors happen. Add null pointer check to avoid
dereferencing null pointer.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
index 5d2ff6791058..acfe1b31e079 100644
--- a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
+++ b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
@@ -176,6 +176,8 @@ void msm_disp_snapshot_add_block(struct msm_disp_state *disp_state, u32 len,
va_list va;
new_blk = kzalloc(sizeof(struct msm_disp_state_block), GFP_KERNEL);
+ if (!new_blk)
+ return;
va_start(va, fmt);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: msm: add null pointer check
2022-03-29 10:34 [PATCH] drm: msm: add null pointer check cgel.zte
@ 2022-03-29 20:55 ` Abhinav Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Abhinav Kumar @ 2022-03-29 20:55 UTC (permalink / raw)
To: cgel.zte, robdclark
Cc: sean, airlied, daniel, dmitry.baryshkov, bjorn.andersson,
lv.ruyi, greenfoo, linux-arm-msm, dri-devel, freedreno,
linux-kernel, Zeal Robot
Seems to be a duplicate of
https://patchwork.freedesktop.org/patch/479378/
Thanks
Abhinav
On 3/29/2022 3:34 AM, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> kzalloc is a memory allocation function which can return NULL when some
> internal memory errors happen. Add null pointer check to avoid
> dereferencing null pointer.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
> index 5d2ff6791058..acfe1b31e079 100644
> --- a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
> +++ b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
> @@ -176,6 +176,8 @@ void msm_disp_snapshot_add_block(struct msm_disp_state *disp_state, u32 len,
> va_list va;
>
> new_blk = kzalloc(sizeof(struct msm_disp_state_block), GFP_KERNEL);
> + if (!new_blk)
> + return;
>
> va_start(va, fmt);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-29 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-29 10:34 [PATCH] drm: msm: add null pointer check cgel.zte
2022-03-29 20:55 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®