mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stian Halseth <stian@itx.no>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	 "David S. Miller" <davem@davemloft.net>,
	Andreas Larsson <andreas@gaisler.com>,
	linux-crypto@vger.kernel.org,  sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: sparc/aes-xts: Add optimization using the AES opcodes
Date: Tue, 29 Sep 2026 23:33:58 +0200	[thread overview]
Message-ID: <a166f1e004b8c2d859232d87a3745f5faa480607.camel@itx.no> (raw)
In-Reply-To: <20260929212459.GA2843629@google.com>

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

Hi Eric,

On Tue, 2026-09-29 at 21:24 +0000, Eric Biggers wrote:
> 
> It's a little late to be adding new optimized code in 7.3.  But yes,
> full AES-XTS performance requires that it be implemented directly, so
> we
> should add this optimized AES-XTS code in 7.4 (assuming people still
> care about SPARC, which I guess you do).  For 7.3 let's just suppress
> "xts-aes-lib" on sparc.  I left it out of the patch
> https://lore.kernel.org/linux-crypto/20260925202353.10763-1-ebiggers@kernel.org/
> , but I guess it should be included after all.
> 
Completely understandable. I was considering sending two patches at
first, one to suppress "xts-aes-lib" on sparc, and one with the
optimized code.
 
You're adding the suppression? 

If yes, I can test the suppression on a T7-1 and a T4-1 when you have
it. 

For 7.4 I could send a v2 on top of it that takes sparc out of the
suppression again, without the Fixes: tag.

And yes, we really do care. The plan here is LUKS on NVMe on the M7 ;-)
SPARC is very much alive and kicking:
https://github.com/sparclinux/issues/issues

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-09-29 21:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 21:12 Stian Halseth
2026-09-29 21:24 ` Eric Biggers
2026-09-29 21:33   ` Stian Halseth [this message]
2026-09-29 22:57     ` Eric Biggers
2026-09-30  6:44       ` Stian Halseth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a166f1e004b8c2d859232d87a3745f5faa480607.camel@itx.no \
    --to=stian@itx.no \
    --cc=Jason@zx2c4.com \
    --cc=andreas@gaisler.com \
    --cc=ardb@kernel.org \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®