Re: [PATCH] lib/crypto: sparc/aes-xts: Add optimization using the AES opcodes

[Stian Halseth <stian@itx.no>]

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]



On Tue, 2026-09-29 at 15:57 -0700, Eric Biggers wrote:
> 
> 
> It's in v3 now:
> https://lore.kernel.org/linux-crypto/20260929222752.36427-1-ebiggers@kernel.org
Thanks, I will test it. Should get the same results as in 7.2 on SPARC.
> 
> > For 7.4 I could send a v2 on top of it that takes sparc out of the
> > suppression again, without the Fixes: tag.
> 
> I suppose.  QEMU support is normally required for new crypto library
> code, so that it is actually testable.  That would rule out adding
> any
> "new" code using the SPARC crypto opcodes until support for them is
> added to QEMU (https://github.com/sparclinux/issues/issues/77).
I will have a look at this issue.
> 
> I might be willing to make an exception for AES-XTS, since otherwise
> for
> parity with the "xts" template the library would need to gain an
> implementation of AES-XTS on top of AES-ECB.  That would be annoying
> since it's inefficient, and SPARC is the *only* architecture that
> would
> need it, as on every other architecture AES-XTS was optimized
> properly.
That would be appreciated. I'll see what I can do on the qemu side, but
that probably won't be in a release any time soon.
> 
> Anyway, I'll be migrating the SPARC optimized AES-{ECB,CBC,CTR} into
> the
> library too.  I'll need your help to test it, since it's completely
> untestable for anyone without SPARC hardware.  (And it will soon the
> only arch with that property now that even s390 is being fixed...)
Just say the word and I will test it.

Best regards,
Stian

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]