From: Dave Jiang <dave.jiang@intel.com>
To: Eder Zulian <ezulian@redhat.com>,
vinicius.gomes@intel.com, vkoul@kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Remove unused pointer and macro
Date: Tue, 8 Apr 2025 15:47:52 -0700 [thread overview]
Message-ID: <a1a54ff1-8b14-4bd0-aba6-c23d8261fd9c@intel.com> (raw)
In-Reply-To: <20250408173829.892317-1-ezulian@redhat.com>
On 4/8/25 10:38 AM, Eder Zulian wrote:
> The pointer 'extern struct kmem_cache *idxd_desc_pool' and the macro
> '#define IDXD_ALLOCATED_BATCH_SIZE 128U' were introduced in commit
> bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data
> accelerators") but they were never used.
>
> Signed-off-by: Eder Zulian <ezulian@redhat.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/idxd.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 214b8039439f..74e6695881e6 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -19,7 +19,6 @@
>
> #define IDXD_DRIVER_VERSION "1.00"
>
> -extern struct kmem_cache *idxd_desc_pool;
> extern bool tc_override;
>
> struct idxd_wq;
> @@ -171,7 +170,6 @@ struct idxd_cdev {
>
> #define DRIVER_NAME_SIZE 128
>
> -#define IDXD_ALLOCATED_BATCH_SIZE 128U
> #define WQ_NAME_SIZE 1024
> #define WQ_TYPE_SIZE 10
>
next prev parent reply other threads:[~2025-04-08 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 17:38 Eder Zulian
2025-04-08 22:47 ` Dave Jiang [this message]
2025-05-14 15:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1a54ff1-8b14-4bd0-aba6-c23d8261fd9c@intel.com \
--to=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=ezulian@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®