* [PATCH] dmaengine: idxd: Remove unused pointer and macro
@ 2025-04-08 17:38 Eder Zulian
2025-04-08 22:47 ` Dave Jiang
2025-05-14 15:03 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Eder Zulian @ 2025-04-08 17:38 UTC (permalink / raw)
To: vinicius.gomes, dave.jiang, vkoul, dmaengine, linux-kernel; +Cc: Eder Zulian
The pointer 'extern struct kmem_cache *idxd_desc_pool' and the macro
'#define IDXD_ALLOCATED_BATCH_SIZE 128U' were introduced in commit
bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data
accelerators") but they were never used.
Signed-off-by: Eder Zulian <ezulian@redhat.com>
---
drivers/dma/idxd/idxd.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
index 214b8039439f..74e6695881e6 100644
--- a/drivers/dma/idxd/idxd.h
+++ b/drivers/dma/idxd/idxd.h
@@ -19,7 +19,6 @@
#define IDXD_DRIVER_VERSION "1.00"
-extern struct kmem_cache *idxd_desc_pool;
extern bool tc_override;
struct idxd_wq;
@@ -171,7 +170,6 @@ struct idxd_cdev {
#define DRIVER_NAME_SIZE 128
-#define IDXD_ALLOCATED_BATCH_SIZE 128U
#define WQ_NAME_SIZE 1024
#define WQ_TYPE_SIZE 10
--
2.49.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove unused pointer and macro
2025-04-08 17:38 [PATCH] dmaengine: idxd: Remove unused pointer and macro Eder Zulian
@ 2025-04-08 22:47 ` Dave Jiang
2025-05-14 15:03 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2025-04-08 22:47 UTC (permalink / raw)
To: Eder Zulian, vinicius.gomes, vkoul, dmaengine, linux-kernel
On 4/8/25 10:38 AM, Eder Zulian wrote:
> The pointer 'extern struct kmem_cache *idxd_desc_pool' and the macro
> '#define IDXD_ALLOCATED_BATCH_SIZE 128U' were introduced in commit
> bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data
> accelerators") but they were never used.
>
> Signed-off-by: Eder Zulian <ezulian@redhat.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/idxd.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 214b8039439f..74e6695881e6 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -19,7 +19,6 @@
>
> #define IDXD_DRIVER_VERSION "1.00"
>
> -extern struct kmem_cache *idxd_desc_pool;
> extern bool tc_override;
>
> struct idxd_wq;
> @@ -171,7 +170,6 @@ struct idxd_cdev {
>
> #define DRIVER_NAME_SIZE 128
>
> -#define IDXD_ALLOCATED_BATCH_SIZE 128U
> #define WQ_NAME_SIZE 1024
> #define WQ_TYPE_SIZE 10
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: idxd: Remove unused pointer and macro
2025-04-08 17:38 [PATCH] dmaengine: idxd: Remove unused pointer and macro Eder Zulian
2025-04-08 22:47 ` Dave Jiang
@ 2025-05-14 15:03 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2025-05-14 15:03 UTC (permalink / raw)
To: vinicius.gomes, dave.jiang, dmaengine, linux-kernel, Eder Zulian
On Tue, 08 Apr 2025 19:38:29 +0200, Eder Zulian wrote:
> The pointer 'extern struct kmem_cache *idxd_desc_pool' and the macro
> '#define IDXD_ALLOCATED_BATCH_SIZE 128U' were introduced in commit
> bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data
> accelerators") but they were never used.
>
>
Applied, thanks!
[1/1] dmaengine: idxd: Remove unused pointer and macro
commit: 3c018bf5a0ee3abe8d579d6a0dda616c3858d7b2
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-14 15:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-08 17:38 [PATCH] dmaengine: idxd: Remove unused pointer and macro Eder Zulian
2025-04-08 22:47 ` Dave Jiang
2025-05-14 15:03 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®