mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH next] media: iris: fix error code in iris_load_fw_to_memory()
@ 2025-02-17  8:08 Dan Carpenter
  2025-02-17  8:12 ` Dikshita Agarwal
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-02-17  8:08 UTC (permalink / raw)
  To: Dikshita Agarwal
  Cc: Vikash Garodia, Abhinav Kumar, Mauro Carvalho Chehab,
	Stefan Schmidt, Hans Verkuil, linux-media, linux-arm-msm,
	linux-kernel, kernel-janitors

Return -ENOMEM if memremap() fails.  Don't return success.

Fixes: d19b163356b8 ("media: iris: implement video firmware load/unload")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/media/platform/qcom/iris/iris_firmware.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c
index 7c493b4a75db..f1b5cd56db32 100644
--- a/drivers/media/platform/qcom/iris/iris_firmware.c
+++ b/drivers/media/platform/qcom/iris/iris_firmware.c
@@ -53,8 +53,10 @@ static int iris_load_fw_to_memory(struct iris_core *core, const char *fw_name)
 	}
 
 	mem_virt = memremap(mem_phys, res_size, MEMREMAP_WC);
-	if (!mem_virt)
+	if (!mem_virt) {
+		ret = -ENOMEM;
 		goto err_release_fw;
+	}
 
 	ret = qcom_mdt_load(dev, firmware, fw_name,
 			    pas_id, mem_virt, mem_phys, res_size, NULL);
-- 
2.47.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH next] media: iris: fix error code in iris_load_fw_to_memory()
  2025-02-17  8:08 [PATCH next] media: iris: fix error code in iris_load_fw_to_memory() Dan Carpenter
@ 2025-02-17  8:12 ` Dikshita Agarwal
  0 siblings, 0 replies; 2+ messages in thread
From: Dikshita Agarwal @ 2025-02-17  8:12 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Vikash Garodia, Abhinav Kumar, Mauro Carvalho Chehab,
	Stefan Schmidt, Hans Verkuil, linux-media, linux-arm-msm,
	linux-kernel, kernel-janitors



On 2/17/2025 1:38 PM, Dan Carpenter wrote:
> Return -ENOMEM if memremap() fails.  Don't return success.
> 
> Fixes: d19b163356b8 ("media: iris: implement video firmware load/unload")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/media/platform/qcom/iris/iris_firmware.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c
> index 7c493b4a75db..f1b5cd56db32 100644
> --- a/drivers/media/platform/qcom/iris/iris_firmware.c
> +++ b/drivers/media/platform/qcom/iris/iris_firmware.c
> @@ -53,8 +53,10 @@ static int iris_load_fw_to_memory(struct iris_core *core, const char *fw_name)
>  	}
>  
>  	mem_virt = memremap(mem_phys, res_size, MEMREMAP_WC);
> -	if (!mem_virt)
> +	if (!mem_virt) {
> +		ret = -ENOMEM;
>  		goto err_release_fw;
> +	}>
>  	ret = qcom_mdt_load(dev, firmware, fw_name,
>  			    pas_id, mem_virt, mem_phys, res_size, NULL);

Thanks for the fix.
Reviewed-by: Dikshita Agarwal <quic_dikshita@quicinc.com>

Thanks,
Dikshita

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-17  8:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-17  8:08 [PATCH next] media: iris: fix error code in iris_load_fw_to_memory() Dan Carpenter
2025-02-17  8:12 ` Dikshita Agarwal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®