From: Pavel Skripkin <paskripkin@gmail.com>
To: Stefan Schmidt <stefan@datenfreihafen.org>,
alex.aring@gmail.com, davem@davemloft.net, kuba@kernel.org
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH v2] ieee802154: atusb: fix uninit value in atusb_set_extended_addr
Date: Tue, 4 Jan 2022 21:11:25 +0300 [thread overview]
Message-ID: <a1f63e82-7a3f-7cf9-ddb3-fc0a863dce40@gmail.com> (raw)
In-Reply-To: <e8e73fcc-b902-4972-6001-84671361146d@datenfreihafen.org>
On 1/4/22 21:04, Stefan Schmidt wrote:
>> Hi Stefan,
>>
>> thanks for testing on real hw.
>>
>> It looks like there is corner case, that Greg mentioned in this thread.
>> atusb_get_and_show_build() reads firmware build info, which may have
>> various length.
>>
>> Maybe we can change atusb_control_msg() to usb_control_msg() in
>> atusb_get_and_show_build(), since other callers do not have this problem
>
> That works for me.
>
Nice! Will prepare v3.
Thanks for testing once again!
> I will also have a look at the use of the modern USB API for next. The
> fix here has a higher prio for me to get in and backported though. Once
> we have this we can look at bigger changes in atusb.
>
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-01-04 18:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAG_fn=VDEoQx5c7XzWX1yaYBd5y5FrG1aagrkv+SZ03c8TfQYQ@mail.gmail.com>
2022-01-02 17:19 ` [PATCH RFT] ieee802154: atusb: move to new USB API Pavel Skripkin
2022-01-02 22:15 ` Alexander Aring
2022-01-02 22:21 ` Pavel Skripkin
2022-01-02 22:36 ` Alexander Aring
2022-01-03 12:09 ` [PATCH v2] ieee802154: atusb: fix uninit value in atusb_set_extended_addr Pavel Skripkin
2022-01-03 15:27 ` Alexander Aring
2022-01-04 15:40 ` Stefan Schmidt
2022-01-04 17:27 ` Pavel Skripkin
2022-01-04 18:04 ` Stefan Schmidt
2022-01-04 18:11 ` Pavel Skripkin [this message]
2022-01-04 18:28 ` [PATCH v3] " Pavel Skripkin
2022-01-04 18:57 ` Alexander Aring
2022-01-04 19:25 ` Stefan Schmidt
2022-01-03 13:04 ` [PATCH RFT] ieee802154: atusb: move to new USB API Greg KH
2022-01-03 13:03 ` Greg KH
2022-01-03 15:35 ` Alexander Aring
2022-01-04 19:41 ` Stefan Schmidt
2022-01-05 8:08 ` Greg KH
2022-01-05 9:01 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1f63e82-7a3f-7cf9-ddb3-fc0a863dce40@gmail.com \
--to=paskripkin@gmail.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=glider@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®