From: Andrew Lunn <andrew@lunn.ch>
To: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
Cc: piergiorgio.beruto@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: phy: phy-c45: add OATC14 10BASE-T1S PHY cable diagnostic support
Date: Tue, 4 Nov 2025 16:46:50 +0100 [thread overview]
Message-ID: <a202e0d0-4ece-4697-89b3-28bd9e3d07b1@lunn.ch> (raw)
In-Reply-To: <20251104102013.63967-2-parthiban.veerasooran@microchip.com>
> +/* Bus Short/Open Status:
> + * 0 0 - no fault; everything is ok. (Default)
> + * 0 1 - detected as an open or missing termination(s)
> + * 1 0 - detected as a short or extra termination(s)
> + * 1 1 - fault but fault type not detectable. More details can be available by
> + * vender specific register if supported.
> + */
> +enum oatc14_hdd_status {
> + OATC14_HDD_STATUS_CABLE_OK,
> + OATC14_HDD_STATUS_OPEN,
> + OATC14_HDD_STATUS_SHORT,
> + OATC14_HDD_STATUS_NOT_DETECTABLE,
You frequently see the first enum has an = 0 at the end. I don't know
what the C standard allows the compiler to do, in terms of assigning
values to these enums, but it won't work if it uses 42, 43, 44, 45.
etc.
Otherwise, this looks O.K.
Andrew
next prev parent reply other threads:[~2025-11-04 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 10:20 [PATCH net-next 0/2] net: phy: microchip_t1s: Add support for LAN867x Rev.D0 PHY Parthiban Veerasooran
2025-11-04 10:20 ` [PATCH net-next 1/2] net: phy: phy-c45: add OATC14 10BASE-T1S PHY cable diagnostic support Parthiban Veerasooran
2025-11-04 15:46 ` Andrew Lunn [this message]
2025-11-05 4:37 ` Parthiban.Veerasooran
2025-11-04 10:20 ` [PATCH net-next 2/2] net: phy: microchip_t1s:: add cable diagnostic support for LAN867x Rev.D0 Parthiban Veerasooran
2025-11-04 15:48 ` Andrew Lunn
2025-11-05 4:39 ` Parthiban.Veerasooran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a202e0d0-4ece-4697-89b3-28bd9e3d07b1@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®