From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v3 4/4] media: qcom: camss: Report hardware version via media controller
Date: Thu, 30 Jul 2026 10:36:52 +0100 [thread overview]
Message-ID: <a24cac0e-7d9a-4293-86e8-9bd0e724c102@linaro.org> (raw)
In-Reply-To: <20260730-camss-version-v3-4-74a87302dd9f@oss.qualcomm.com>
On 30/07/2026 10:24, Loic Poulain wrote:
> +static int camss_read_version(struct camss *camss)
> +{
> + u32 hw_version;
> + int ret;
> +
> + if (!camss->top_base || !camss->res->pm_clks[0])
> + return 0;
> +
> + ret = pm_runtime_resume_and_get(camss->dev);
> + if (ret < 0)
> + return ret;
> +
> + hw_version = readl_relaxed(camss->top_base + CAMSS_HW_VERSION);
I'm virtually sure this fails on !PM_CLK
---
bod
prev parent reply other threads:[~2026-07-30 9:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 9:24 [PATCH v3 0/4] media: qcom: camss: Report CAMSS " Loic Poulain
2026-07-30 9:24 ` [PATCH v3 1/4] media: qcom: camss: Add PM clock support and integrate with runtime PM Loic Poulain
2026-07-30 9:35 ` Bryan O'Donoghue
2026-07-30 9:49 ` Loic Poulain
2026-07-30 19:34 ` Bryan O'Donoghue
2026-07-31 8:31 ` Loic Poulain
2026-07-30 9:24 ` [PATCH v3 2/4] media: qcom: camss: Add PM clock definitions for QCM2290 Loic Poulain
2026-07-30 9:24 ` [PATCH v3 3/4] media: qcom: camss: Drop top_ahb/ahb/axi from QCM2290 subdevice clocks Loic Poulain
2026-07-30 9:24 ` [PATCH v3 4/4] media: qcom: camss: Report hardware version via media controller Loic Poulain
2026-07-30 9:36 ` Bryan O'Donoghue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a24cac0e-7d9a-4293-86e8-9bd0e724c102@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®