* [PATCH -next] pinctrl: da9062: Fix error gpiolib.h path
@ 2020-02-28 4:00 YueHaibing
2020-02-28 6:30 ` Yuehaibing
2020-02-28 6:34 ` [PATCH v2 " YueHaibing
0 siblings, 2 replies; 5+ messages in thread
From: YueHaibing @ 2020-02-28 4:00 UTC (permalink / raw)
To: support.opensource, linus.walleij, Adam.Thomson.Opensource, m.felsch
Cc: linux-gpio, linux-kernel, YueHaibing
drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
#include <../gpio/gpiolib.h>
^~~~~~~~~~~~~~~~~~~
Fix this wrong include path.
Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pinctrl/pinctrl-da9062.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
index f704ee0b2fd9..c15eb6e99bc1 100644
--- a/drivers/pinctrl/pinctrl-da9062.c
+++ b/drivers/pinctrl/pinctrl-da9062.c
@@ -25,7 +25,7 @@
* We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
* the gpio is active low without a vendor specific dt-binding.
*/
-#include <../gpio/gpiolib.h>
+#include "../../gpio/gpiolib.h"
#define DA9062_TYPE(offset) (4 * (offset % 2))
#define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] pinctrl: da9062: Fix error gpiolib.h path
2020-02-28 4:00 [PATCH -next] pinctrl: da9062: Fix error gpiolib.h path YueHaibing
@ 2020-02-28 6:30 ` Yuehaibing
2020-02-28 6:34 ` [PATCH v2 " YueHaibing
1 sibling, 0 replies; 5+ messages in thread
From: Yuehaibing @ 2020-02-28 6:30 UTC (permalink / raw)
To: support.opensource, linus.walleij, Adam.Thomson.Opensource, m.felsch
Cc: linux-gpio, linux-kernel
Sorry, pls ignore this, will resend v2.
On 2020/2/28 12:00, YueHaibing wrote:
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
> #include <../gpio/gpiolib.h>
> ^~~~~~~~~~~~~~~~~~~
>
> Fix this wrong include path.
>
> Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pinctrl/pinctrl-da9062.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
> index f704ee0b2fd9..c15eb6e99bc1 100644
> --- a/drivers/pinctrl/pinctrl-da9062.c
> +++ b/drivers/pinctrl/pinctrl-da9062.c
> @@ -25,7 +25,7 @@
> * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
> * the gpio is active low without a vendor specific dt-binding.
> */
> -#include <../gpio/gpiolib.h>
> +#include "../../gpio/gpiolib.h"
>
> #define DA9062_TYPE(offset) (4 * (offset % 2))
> #define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 -next] pinctrl: da9062: Fix error gpiolib.h path
2020-02-28 4:00 [PATCH -next] pinctrl: da9062: Fix error gpiolib.h path YueHaibing
2020-02-28 6:30 ` Yuehaibing
@ 2020-02-28 6:34 ` YueHaibing
2020-02-28 6:59 ` Marco Felsch
2020-02-28 13:16 ` Linus Walleij
1 sibling, 2 replies; 5+ messages in thread
From: YueHaibing @ 2020-02-28 6:34 UTC (permalink / raw)
To: support.opensource, linus.walleij, Adam.Thomson.Opensource, m.felsch
Cc: linux-gpio, linux-kernel, YueHaibing
gcc 7.4.0 build fails:
drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
#include <../gpio/gpiolib.h>
^~~~~~~~~~~~~~~~~~~
Fix this wrong include path.
Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: Fix wrong path
---
drivers/pinctrl/pinctrl-da9062.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
index f704ee0b2fd9..c15eb6e99bc1 100644
--- a/drivers/pinctrl/pinctrl-da9062.c
+++ b/drivers/pinctrl/pinctrl-da9062.c
@@ -25,7 +25,7 @@
* We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
* the gpio is active low without a vendor specific dt-binding.
*/
-#include <../gpio/gpiolib.h>
+#include "../gpio/gpiolib.h"
#define DA9062_TYPE(offset) (4 * (offset % 2))
#define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 -next] pinctrl: da9062: Fix error gpiolib.h path
2020-02-28 6:34 ` [PATCH v2 " YueHaibing
@ 2020-02-28 6:59 ` Marco Felsch
2020-02-28 13:16 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Marco Felsch @ 2020-02-28 6:59 UTC (permalink / raw)
To: YueHaibing
Cc: support.opensource, linus.walleij, Adam.Thomson.Opensource,
linux-gpio, linux-kernel
Hi YueHaibing,
thanks for covering that and sorry for that bug. Didn't covered that
because I'm using a newer toolchain.
On 20-02-28 14:34, YueHaibing wrote:
> gcc 7.4.0 build fails:
>
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
> #include <../gpio/gpiolib.h>
> ^~~~~~~~~~~~~~~~~~~
>
> Fix this wrong include path.
nit, the path isn't wrong. Whats wrong is the syntax.
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: Fix wrong path
> ---
> drivers/pinctrl/pinctrl-da9062.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
> index f704ee0b2fd9..c15eb6e99bc1 100644
> --- a/drivers/pinctrl/pinctrl-da9062.c
> +++ b/drivers/pinctrl/pinctrl-da9062.c
> @@ -25,7 +25,7 @@
> * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
> * the gpio is active low without a vendor specific dt-binding.
> */
> -#include <../gpio/gpiolib.h>
> +#include "../gpio/gpiolib.h"
>
> #define DA9062_TYPE(offset) (4 * (offset % 2))
> #define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
> --
> 2.17.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 -next] pinctrl: da9062: Fix error gpiolib.h path
2020-02-28 6:34 ` [PATCH v2 " YueHaibing
2020-02-28 6:59 ` Marco Felsch
@ 2020-02-28 13:16 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2020-02-28 13:16 UTC (permalink / raw)
To: YueHaibing
Cc: Support Opensource, Adam Thomson, Marco Felsch,
open list:GPIO SUBSYSTEM, linux-kernel
On Fri, Feb 28, 2020 at 7:35 AM YueHaibing <yuehaibing@huawei.com> wrote:
> gcc 7.4.0 build fails:
>
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
> #include <../gpio/gpiolib.h>
> ^~~~~~~~~~~~~~~~~~~
>
> Fix this wrong include path.
>
> Fixes: 56cc3af4e8c8 ("pinctrl: da9062: add driver support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: Fix wrong path
Good catch!
Patch applied with Marco's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-28 13:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 4:00 [PATCH -next] pinctrl: da9062: Fix error gpiolib.h path YueHaibing
2020-02-28 6:30 ` Yuehaibing
2020-02-28 6:34 ` [PATCH v2 " YueHaibing
2020-02-28 6:59 ` Marco Felsch
2020-02-28 13:16 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®