* [PATCH 02/15] ARM: dts: socfpga: align NAND controller name with bindings
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 03/15] arm64: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings expect NAND controller node name to match certain patterns:
socfpga_arria10_socdk_nand.dtb: nand@ffb90000: $nodename:0: 'nand@ffb90000' does not match '^nand-controller(@.*)?'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/intel/socfpga/socfpga.dtsi | 2 +-
arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi b/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
index 4c1d140f40f8..35be14150f41 100644
--- a/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
+++ b/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
@@ -768,7 +768,7 @@ mmc: mmc@ff704000 {
status = "disabled";
};
- nand0: nand@ff900000 {
+ nand0: nand-controller@ff900000 {
#address-cells = <0x1>;
#size-cells = <0x0>;
compatible = "altr,socfpga-denali-nand";
diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
index f36063c57c7f..6b6e77596ffa 100644
--- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
+++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
@@ -669,7 +669,7 @@ mmc: mmc@ff808000 {
status = "disabled";
};
- nand: nand@ffb90000 {
+ nand: nand-controller@ffb90000 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "altr,socfpga-denali-nand";
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 03/15] arm64: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 02/15] ARM: dts: socfpga: align NAND controller name with bindings Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 04/15] arm64: dts: socfpga: stratix10: add clock-names to DWC2 USB Krzysztof Kozlowski
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
cdns,page-size and cdns,block-size are neither documented nor used by
Linux, so remove them to fix dtbs_check warnings like:
socfpga_n5x_socdk.dtb: flash@0: Unevaluated properties are not allowed ('cdns,block-size', 'cdns,page-size' were unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 --
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts | 2 --
arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 2 --
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 2 --
4 files changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 468fcc7da066..347fd1d949fa 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -187,8 +187,6 @@ flash@0 {
spi-max-frequency = <100000000>;
m25p,fast-read;
- cdns,page-size = <256>;
- cdns,block-size = <16>;
cdns,read-delay = <1>;
cdns,tshsl-ns = <50>;
cdns,tsd2d-ns = <50>;
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
index 532164a6354c..4e73e6656d72 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
@@ -176,8 +176,6 @@ flash@0 {
spi-max-frequency = <100000000>;
m25p,fast-read;
- cdns,page-size = <256>;
- cdns,block-size = <16>;
cdns,read-delay = <1>;
cdns,tshsl-ns = <50>;
cdns,tsd2d-ns = <50>;
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
index 053690657675..ad99aefeb185 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
@@ -113,8 +113,6 @@ flash@0 {
spi-max-frequency = <100000000>;
m25p,fast-read;
- cdns,page-size = <256>;
- cdns,block-size = <16>;
cdns,read-delay = <2>;
cdns,tshsl-ns = <50>;
cdns,tsd2d-ns = <50>;
diff --git a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
index 5ddfdff37c25..de82a552dc26 100644
--- a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
@@ -91,8 +91,6 @@ flash@0 {
spi-max-frequency = <100000000>;
m25p,fast-read;
- cdns,page-size = <256>;
- cdns,block-size = <16>;
cdns,read-delay = <2>;
cdns,tshsl-ns = <50>;
cdns,tsd2d-ns = <50>;
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 04/15] arm64: dts: socfpga: stratix10: add clock-names to DWC2 USB
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 02/15] ARM: dts: socfpga: align NAND controller name with bindings Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 03/15] arm64: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 05/15] arm64: dts: socfpga: stratix10: align pincfg nodes with bindings Krzysztof Kozlowski
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The DWC2 USB bindings require clock-names property, to provide such to
fix warnings like:
socfpga_stratix10_swvp.dtb: usb@ffb40000: 'clock-names' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 439497ab967d..1a743787fef6 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -510,6 +510,7 @@ usb1: usb@ffb40000 {
resets = <&rst USB1_RESET>, <&rst USB1_OCP_RESET>;
reset-names = "dwc2", "dwc2-ecc";
clocks = <&clkmgr STRATIX10_USB_CLK>;
+ clock-names = "otg";
iommus = <&smmu 7>;
status = "disabled";
};
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 05/15] arm64: dts: socfpga: stratix10: align pincfg nodes with bindings
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 04/15] arm64: dts: socfpga: stratix10: add clock-names to DWC2 USB Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 06/15] arm64: dts: socfpga: stratix10: move FPGA region out of soc node Krzysztof Kozlowski
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
pinctrl-single bindings require pin configuration node names to match
certain patterns:
socfpga_stratix10_socdk.dtb: pinctrl@ffd13000: 'i2c1-pmx-func', 'i2c1-pmx-func-gpio'
do not match any of the regexes: '-pins(-[0-9]+)?$|-pin$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 347fd1d949fa..5578196a2c9a 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -66,14 +66,14 @@ sdmmca-ecc@ff8c8c00 {
};
&pinctrl0 {
- i2c1_pmx_func: i2c1-pmx-func {
+ i2c1_pmx_func: i2c1-pmx-func-pins {
pinctrl-single,pins = <
0x78 0x4 /* I2C1_SDA (IO6-B) PIN30SEL) */
0x7c 0x4 /* I2C1_SCL (IO7-B) PIN31SEL */
>;
};
- i2c1_pmx_func_gpio: i2c1-pmx-func-gpio {
+ i2c1_pmx_func_gpio: i2c1-pmx-func-gpio-pins {
pinctrl-single,pins = <
0x78 0x8 /* I2C1_SDA (IO6-B) PIN30SEL) */
0x7c 0x8 /* I2C1_SCL (IO7-B) PIN31SEL */
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 06/15] arm64: dts: socfpga: stratix10: move FPGA region out of soc node
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (3 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 05/15] arm64: dts: socfpga: stratix10: align pincfg nodes with bindings Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 07/15] arm64: dts: socfpga: stratix10: move firmware " Krzysztof Kozlowski
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The "soc" node is supposed to have only MMIO children, so move the FPGA
region node to top level to fix dtc W=1 warnings like:
socfpga_stratix10.dtsi:136.20-141.5: Warning (simple_bus_reg): /soc@0/base_fpga_region: missing or empty reg/ranges property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested
---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 1a743787fef6..ec086ffcc4a2 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -59,6 +59,13 @@ cpu3: cpu@3 {
};
};
+ fpga-region {
+ compatible = "fpga-region";
+ #address-cells = <0x2>;
+ #size-cells = <0x2>;
+ fpga-mgr = <&fpga_mgr>;
+ };
+
pmu {
compatible = "arm,armv8-pmuv3";
interrupts = <0 170 4>,
@@ -133,13 +140,6 @@ soc {
interrupt-parent = <&intc>;
ranges = <0 0 0 0xffffffff>;
- base_fpga_region {
- #address-cells = <0x2>;
- #size-cells = <0x2>;
- compatible = "fpga-region";
- fpga-mgr = <&fpga_mgr>;
- };
-
clkmgr: clock-controller@ffd10000 {
compatible = "intel,stratix10-clkmgr";
reg = <0xffd10000 0x1000>;
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 07/15] arm64: dts: socfpga: stratix10: move firmware out of soc node
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (4 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 06/15] arm64: dts: socfpga: stratix10: move FPGA region out of soc node Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 08/15] arm64: dts: socfpga: stratix10: add unit address to " Krzysztof Kozlowski
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The "soc" node is supposed to have only MMIO children, so move the
firmware/svc node to top level to fix dtc W=1 warnings like:
socfpga_stratix10.dtsi:625.12-635.5: Warning (simple_bus_reg): /soc@0/firmware: missing or empty reg/ranges property
The node should still be instantiated by drivers/of/platform.c, just
like in all other platforms.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested
---
.../boot/dts/altera/socfpga_stratix10.dtsi | 24 +++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index ec086ffcc4a2..59075b958048 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -59,6 +59,18 @@ cpu3: cpu@3 {
};
};
+ firmware {
+ svc {
+ compatible = "intel,stratix10-svc";
+ method = "smc";
+ memory-region = <&service_reserved>;
+
+ fpga_mgr: fpga-mgr {
+ compatible = "intel,stratix10-soc-fpga-mgr";
+ };
+ };
+ };
+
fpga-region {
compatible = "fpga-region";
#address-cells = <0x2>;
@@ -621,18 +633,6 @@ qspi: spi@ff8d2000 {
status = "disabled";
};
-
- firmware {
- svc {
- compatible = "intel,stratix10-svc";
- method = "smc";
- memory-region = <&service_reserved>;
-
- fpga_mgr: fpga-mgr {
- compatible = "intel,stratix10-soc-fpga-mgr";
- };
- };
- };
};
usbphy0: usbphy0 {
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 08/15] arm64: dts: socfpga: stratix10: add unit address to soc node
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (5 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 07/15] arm64: dts: socfpga: stratix10: move firmware " Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 09/15] arm64: dts: socfpga: stratix10_socdk: align NAND chip name with bindings Krzysztof Kozlowski
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The "soc" node has ranges with addresses, so it is should have unit
address to fix dtc W=1 warnings like:
socfpga_stratix10.dtsi:128.6-636.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested.
---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 +-
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 +-
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 59075b958048..072fe20cfca0 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -144,7 +144,7 @@ qspi_clk: qspi-clk {
};
};
- soc {
+ soc@0 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "simple-bus";
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 5578196a2c9a..26173f0b0051 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -51,7 +51,7 @@ ref_033v: regulator-v-ref {
regulator-max-microvolt = <330000>;
};
- soc {
+ soc@0 {
eccmgr {
sdmmca-ecc@ff8c8c00 {
compatible = "altr,socfpga-s10-sdmmc-ecc",
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
index 4e73e6656d72..88e1afdb2583 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
@@ -51,7 +51,7 @@ ref_033v: regulator-v-ref {
regulator-max-microvolt = <330000>;
};
- soc {
+ soc@0 {
eccmgr {
sdmmca-ecc@ff8c8c00 {
compatible = "altr,socfpga-s10-sdmmc-ecc",
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 09/15] arm64: dts: socfpga: stratix10_socdk: align NAND chip name with bindings
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (6 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 08/15] arm64: dts: socfpga: stratix10: add unit address to " Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 10/15] arm64: dts: socfpga: stratix10_swvp: drop unsupported DW MSHC properties Krzysztof Kozlowski
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings expect NAND child node name to match certain patterns:
socfpga_agilex_socdk_nand.dtb: nand-controller@ffb90000: Unevaluated properties are not allowed ('flash@0' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
index 88e1afdb2583..81d0e914a77c 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dts
@@ -102,7 +102,7 @@ phy0: ethernet-phy@0 {
&nand {
status = "okay";
- flash@0 {
+ nand@0 {
reg = <0>;
#address-cells = <1>;
#size-cells = <1>;
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 10/15] arm64: dts: socfpga: stratix10_swvp: drop unsupported DW MSHC properties
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (7 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 09/15] arm64: dts: socfpga: stratix10_socdk: align NAND chip name with bindings Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 11/15] arm64: dts: socfpga: agilex: align pin-controller name with bindings Krzysztof Kozlowski
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
altr,dw-mshc-ciu-div and altr,dw-mshc-sdr-timing are neither documented
nor used by Linux, so remove them to fix dtbs_check warnings like:
socfpga_stratix10_swvp.dtb: mmc@ff808000: Unevaluated properties are not allowed
('altr,dw-mshc-ciu-div', 'altr,dw-mshc-sdr-timing' were unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
index ff413f8e3b07..0d837d3e65a5 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
@@ -80,8 +80,6 @@ &gmac2 {
&mmc {
status = "okay";
- altr,dw-mshc-ciu-div = <0x3>;
- altr,dw-mshc-sdr-timing = <0x0 0x3>;
cap-sd-highspeed;
cap-mmc-highspeed;
broken-cd;
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 11/15] arm64: dts: socfpga: agilex: align pin-controller name with bindings
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (8 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 10/15] arm64: dts: socfpga: stratix10_swvp: drop unsupported DW MSHC properties Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 12/15] arm64: dts: socfpga: agilex: move FPGA region out of soc node Krzysztof Kozlowski
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Use a generic node name for the pin controller node to fix:
/socfpga_agilex_n6000.dtb: pinconf@ffd13100: $nodename:0: 'pinconf@ffd13100' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index d3adb6a130ae..de1453a951d6 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -368,7 +368,7 @@ pinctrl0: pinctrl@ffd13000 {
pinctrl-single,function-mask = <0x0000000f>;
};
- pinctrl1: pinconf@ffd13100 {
+ pinctrl1: pinctrl@ffd13100 {
compatible = "pinctrl-single";
#pinctrl-cells = <1>;
reg = <0xffd13100 0x20>;
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 12/15] arm64: dts: socfpga: agilex: move FPGA region out of soc node
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (9 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 11/15] arm64: dts: socfpga: agilex: align pin-controller name with bindings Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 13/15] arm64: dts: socfpga: agilex: move firmware " Krzysztof Kozlowski
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The "soc" node is supposed to have only MMIO children, so move the FPGA
region node to top level to fix dtc W=1 warnings like:
socfpga_agilex.dtsi:141.20-146.5: Warning (simple_bus_reg): /soc@0/base_fpga_region: missing or empty reg/ranges property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested
---
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index de1453a951d6..77d03caea25b 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -60,6 +60,13 @@ cpu3: cpu@3 {
};
};
+ fpga-region {
+ compatible = "fpga-region";
+ #address-cells = <0x2>;
+ #size-cells = <0x2>;
+ fpga-mgr = <&fpga_mgr>;
+ };
+
pmu {
compatible = "arm,armv8-pmuv3";
interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>,
@@ -138,13 +145,6 @@ soc {
interrupt-parent = <&intc>;
ranges = <0 0 0 0xffffffff>;
- base_fpga_region {
- #address-cells = <0x2>;
- #size-cells = <0x2>;
- compatible = "fpga-region";
- fpga-mgr = <&fpga_mgr>;
- };
-
clkmgr: clock-controller@ffd10000 {
compatible = "intel,agilex-clkmgr";
reg = <0xffd10000 0x1000>;
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 13/15] arm64: dts: socfpga: agilex: move firmware out of soc node
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (10 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 12/15] arm64: dts: socfpga: agilex: move FPGA region out of soc node Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 14/15] arm64: dts: socfpga: agilex: add unit address to " Krzysztof Kozlowski
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The "soc" node is supposed to have only MMIO children, so move the
firmware/svc node to top level to fix dtc W=1 warnings like:
socfpga_agilex.dtsi:663.12-673.5: Warning (simple_bus_reg): /soc@0/firmware: missing or empty reg/ranges property
The node should still be instantiated by drivers/of/platform.c, just
like in all other platforms.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested
---
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 24 +++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index 77d03caea25b..8792291a0175 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -60,6 +60,18 @@ cpu3: cpu@3 {
};
};
+ firmware {
+ svc {
+ compatible = "intel,agilex-svc";
+ method = "smc";
+ memory-region = <&service_reserved>;
+
+ fpga_mgr: fpga-mgr {
+ compatible = "intel,agilex-soc-fpga-mgr";
+ };
+ };
+ };
+
fpga-region {
compatible = "fpga-region";
#address-cells = <0x2>;
@@ -659,17 +671,5 @@ qspi: spi@ff8d2000 {
status = "disabled";
};
-
- firmware {
- svc {
- compatible = "intel,agilex-svc";
- method = "smc";
- memory-region = <&service_reserved>;
-
- fpga_mgr: fpga-mgr {
- compatible = "intel,agilex-soc-fpga-mgr";
- };
- };
- };
};
};
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 14/15] arm64: dts: socfpga: agilex: add unit address to soc node
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (11 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 13/15] arm64: dts: socfpga: agilex: move firmware " Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-09 17:30 ` [PATCH 15/15] arm64: dts: socfpga: agilex: drop redundant status Krzysztof Kozlowski
2023-12-13 1:10 ` [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Dinh Nguyen
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The "soc" node has ranges with addresses, so it is should have unit
address to fix dtc W=1 warnings like:
socfpga_agilex.dtsi:152.6-674.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested.
---
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 +-
arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts | 2 +-
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index 8792291a0175..76aafa172eb0 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -149,7 +149,7 @@ usbphy0: usbphy {
compatible = "usb-nop-xceiv";
};
- soc {
+ soc@0 {
#address-cells = <1>;
#size-cells = <1>;
compatible = "simple-bus";
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
index 1a32840c74e0..d22de06e9839 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
@@ -26,7 +26,7 @@ memory@80000000 {
reg = <0 0x80000000 0 0>;
};
- soc {
+ soc@0 {
bus@80000000 {
compatible = "simple-bus";
reg = <0x80000000 0x60000000>,
diff --git a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
index de82a552dc26..f2e2346dd3c4 100644
--- a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
@@ -25,7 +25,7 @@ memory@80000000 {
reg = <0 0x80000000 0 0>;
};
- soc {
+ soc@0 {
sdram_edac: memory-controller@f87f8000 {
compatible = "snps,ddrc-3.80a";
reg = <0xf87f8000 0x400>;
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 15/15] arm64: dts: socfpga: agilex: drop redundant status
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (12 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 14/15] arm64: dts: socfpga: agilex: add unit address to " Krzysztof Kozlowski
@ 2023-12-09 17:30 ` Krzysztof Kozlowski
2023-12-13 1:10 ` [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Dinh Nguyen
14 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 17:30 UTC (permalink / raw)
To: Dinh Nguyen, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
New device nodes are enabled by default.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
index f2e2346dd3c4..2d70a92c2090 100644
--- a/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dts
@@ -30,7 +30,6 @@ sdram_edac: memory-controller@f87f8000 {
compatible = "snps,ddrc-3.80a";
reg = <0xf87f8000 0x400>;
interrupts = <0 175 4>;
- status = "okay";
};
};
};
--
2.34.1
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size
2023-12-09 17:30 [PATCH 01/15] ARM: dts: socfpga: drop unsupported cdns,page-size and cdns,block-size Krzysztof Kozlowski
` (13 preceding siblings ...)
2023-12-09 17:30 ` [PATCH 15/15] arm64: dts: socfpga: agilex: drop redundant status Krzysztof Kozlowski
@ 2023-12-13 1:10 ` Dinh Nguyen
14 siblings, 0 replies; 16+ messages in thread
From: Dinh Nguyen @ 2023-12-13 1:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, devicetree, linux-kernel
On 12/9/23 11:30, Krzysztof Kozlowski wrote:
> cdns,page-size and cdns,block-size are neither documented nor used by
> Linux, so remove them to fix dtbs_check warnings like:
>
> socfpga_arria5_socdk.dtb: flash@0: Unevaluated properties are not allowed ('cdns,block-size', 'cdns,page-size' were unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>
Whole series applied, thanks!
Dinh
^ permalink raw reply [flat|nested] 16+ messages in thread