From: Alexandre Mergnat <amergnat@baylibre.com>
To: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Jason-ch Chen <jason-ch.chen@mediatek.com>,
Johnson Wang <johnson.wang@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
Nancy Lin <nancy.lin@mediatek.com>,
Shawn Sung <shawn.sung@mediatek.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3 4/4] drm/mediatek: Fix dereference before null check
Date: Wed, 21 Jun 2023 14:38:47 +0200 [thread overview]
Message-ID: <a2adfff3-1fc5-b3ab-c4a8-df06dbf5bb17@baylibre.com> (raw)
In-Reply-To: <20230621102247.10116-5-jason-jh.lin@mediatek.com>
On 21/06/2023 12:22, Jason-JH.Lin wrote:
> Null-checking state suggests that it may be null, but it has already
> been dereferenced on drm_atomic_get_new_plane_state(state, plane).
>
> The parameter state will never be NULL currently, so just remove the
> state is NULL flow in this function.
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-06-21 12:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230621102247.10116-1-jason-jh.lin@mediatek.com>
[not found] ` <20230621102247.10116-2-jason-jh.lin@mediatek.com>
2023-06-21 12:12 ` [PATCH v3 1/4] drm/mediatek: Remove freeing not dynamic allocated memory Alexandre Mergnat
2023-07-10 4:01 ` CK Hu (胡俊光)
[not found] ` <20230621102247.10116-3-jason-jh.lin@mediatek.com>
2023-06-21 12:15 ` [PATCH v3 2/4] drm/mediatek: Add cnt checking for coverity issue Alexandre Mergnat
2023-07-10 6:45 ` CK Hu (胡俊光)
[not found] ` <20230621102247.10116-4-jason-jh.lin@mediatek.com>
2023-06-21 12:34 ` [PATCH v3 3/4] drm/mediatek: Add casting before assign Alexandre Mergnat
2023-06-22 8:02 ` Jason-JH Lin (林睿祥)
2023-07-12 13:07 ` Alexandre Mergnat
2023-07-14 5:45 ` CK Hu (胡俊光)
2023-07-14 6:45 ` Jason-JH Lin (林睿祥)
2023-07-17 13:17 ` David Laight
2023-07-18 15:30 ` Jason-JH Lin (林睿祥)
[not found] ` <20230621102247.10116-5-jason-jh.lin@mediatek.com>
2023-06-21 12:38 ` Alexandre Mergnat [this message]
2023-07-14 5:52 ` [PATCH v3 4/4] drm/mediatek: Fix dereference before null check CK Hu (胡俊光)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2adfff3-1fc5-b3ab-c4a8-df06dbf5bb17@baylibre.com \
--to=amergnat@baylibre.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-ch.chen@mediatek.com \
--cc=jason-jh.lin@mediatek.com \
--cc=johnson.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nancy.lin@mediatek.com \
--cc=shawn.sung@mediatek.com \
--cc=singo.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®