From: Alexandre Mergnat <amergnat@baylibre.com>
To: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
"Johnson Wang (王聖鑫)" <Johnson.Wang@mediatek.com>,
"Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>,
"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign
Date: Wed, 12 Jul 2023 15:07:46 +0200 [thread overview]
Message-ID: <aa92a6da-b406-59c3-8d2e-084bee6ba778@baylibre.com> (raw)
In-Reply-To: <4d7f86a662429256e5a0a5a52b9e8c375b22c382.camel@mediatek.com>
On 22/06/2023 10:02, Jason-JH Lin (林睿祥) wrote:
>> drm_plane_state *new_state,
>> > dma_addr_t addr;
>> > dma_addr_t hdr_addr = 0;
>> > unsigned int hdr_pitch = 0;
>> > +int offset;
>>
>> I agree with Angelo, please set offset as unsigned.
>>
> I think offset should be unsigned, but since src.x1 and src.y1 are
> 'int'. That means 'unsigned int' offset will be very big when src.x1 or
> src.y1 is negative.
> So I just use 'int' for offset here.
Ok
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-07-12 13:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230621102247.10116-1-jason-jh.lin@mediatek.com>
[not found] ` <20230621102247.10116-4-jason-jh.lin@mediatek.com>
2023-06-21 12:34 ` Alexandre Mergnat
2023-06-22 8:02 ` Jason-JH Lin (林睿祥)
2023-07-12 13:07 ` Alexandre Mergnat [this message]
2023-07-14 5:45 ` CK Hu (胡俊光)
2023-07-14 6:45 ` Jason-JH Lin (林睿祥)
2023-07-17 13:17 ` David Laight
2023-07-18 15:30 ` Jason-JH Lin (林睿祥)
[not found] ` <20230621102247.10116-5-jason-jh.lin@mediatek.com>
2023-06-21 12:38 ` [PATCH v3 4/4] drm/mediatek: Fix dereference before null check Alexandre Mergnat
2023-07-14 5:52 ` CK Hu (胡俊光)
[not found] ` <20230621102247.10116-2-jason-jh.lin@mediatek.com>
2023-06-21 12:12 ` [PATCH v3 1/4] drm/mediatek: Remove freeing not dynamic allocated memory Alexandre Mergnat
2023-07-10 4:01 ` CK Hu (胡俊光)
[not found] ` <20230621102247.10116-3-jason-jh.lin@mediatek.com>
2023-06-21 12:15 ` [PATCH v3 2/4] drm/mediatek: Add cnt checking for coverity issue Alexandre Mergnat
2023-07-10 6:45 ` CK Hu (胡俊光)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa92a6da-b406-59c3-8d2e-084bee6ba778@baylibre.com \
--to=amergnat@baylibre.com \
--cc=Jason-JH.Lin@mediatek.com \
--cc=Jason-ch.Chen@mediatek.com \
--cc=Johnson.Wang@mediatek.com \
--cc=Nancy.Lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Shawn.Sung@mediatek.com \
--cc=Singo.Chang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®