From: Jens Axboe <axboe@kernel.dk>
To: Paolo Valente <paolo.valente@linaro.org>, Tejun Heo <tj@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
broonie@kernel.org
Subject: Re: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe
Date: Fri, 19 May 2017 08:37:07 -0600 [thread overview]
Message-ID: <a2b424cb-202a-5a0d-8850-dd5e3332dd8b@kernel.dk> (raw)
In-Reply-To: <20170519083908.2588-1-paolo.valente@linaro.org>
On 05/19/2017 02:39 AM, Paolo Valente wrote:
> @@ -692,8 +725,7 @@ void bfq_pd_offline(struct blkg_policy_data *pd)
> /*
> * The idle tree may still contain bfq_queues belonging
> * to exited task because they never migrated to a different
> - * cgroup from the one being destroyed now. No one else
> - * can access them so it's safe to act without any lock.
> ++ * cgroup from the one being destroyed now.
> */
> bfq_flush_idle_tree(st);
>
Looks like an extra '+' snuck into that hunk.
--
Jens Axboe
next prev parent reply other threads:[~2017-05-19 14:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 8:39 Paolo Valente
2017-05-19 14:37 ` Jens Axboe [this message]
2017-05-22 20:20 ` Paolo Valente
2017-05-19 14:54 ` Tejun Heo
2017-05-20 7:27 ` Paolo Valente
2017-05-23 20:42 ` Tejun Heo
2017-05-24 11:53 ` Paolo Valente
2017-05-24 14:24 ` Paolo Valente
2017-05-24 14:50 ` Tejun Heo
2017-05-24 16:43 ` Paolo Valente
2017-05-24 16:47 ` Tejun Heo
2017-05-25 7:10 ` Paolo Valente
2017-05-25 14:37 ` Tejun Heo
2017-06-05 8:11 Paolo Valente
2017-06-08 15:30 ` Paolo Valente
2017-06-08 15:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2b424cb-202a-5a0d-8850-dd5e3332dd8b@kernel.dk \
--to=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®