* [PATCH -next] mtd/ftl: Fix uaf in ftl_remove_dev()
@ 2022-07-15 7:11 Gaosheng Cui
2022-08-18 1:32 ` cuigaosheng
0 siblings, 1 reply; 2+ messages in thread
From: Gaosheng Cui @ 2022-07-15 7:11 UTC (permalink / raw)
To: cuigaosheng1, miquel.raynal, richard, vigneshr
Cc: linux-mtd, linux-kernel, gongruiqi1, wangweiyang2
del_mtd_blktrans_dev will reclaim the resources of mtd_blktrans_dev,
and call kfree(dev) in blktrans_dev_put to release the memory of
mtd_blktrans_dev, so when ftl_freepart reclaims the memory of other
member pointers of the partition_t, it will trigger the uaf problem,
Fix it by moving ftl_freepart in front of del_mtd_blktrans_dev.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
drivers/mtd/ftl.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c
index 200271bdc7aa..bec56070039d 100644
--- a/drivers/mtd/ftl.c
+++ b/drivers/mtd/ftl.c
@@ -1039,8 +1039,12 @@ static void ftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
static void ftl_remove_dev(struct mtd_blktrans_dev *dev)
{
+ struct partition_t *partition;
+
+ partition = container_of(dev, struct partition_t, mbd);
+
+ ftl_freepart(partition);
del_mtd_blktrans_dev(dev);
- ftl_freepart((partition_t *)dev);
}
static struct mtd_blktrans_ops ftl_tr = {
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mtd/ftl: Fix uaf in ftl_remove_dev()
2022-07-15 7:11 [PATCH -next] mtd/ftl: Fix uaf in ftl_remove_dev() Gaosheng Cui
@ 2022-08-18 1:32 ` cuigaosheng
0 siblings, 0 replies; 2+ messages in thread
From: cuigaosheng @ 2022-08-18 1:32 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr, cuigaosheng1
Cc: linux-mtd, linux-kernel, gongruiqi1, wangweiyang2
PING
在 2022/7/15 15:11, Gaosheng Cui 写道:
> del_mtd_blktrans_dev will reclaim the resources of mtd_blktrans_dev,
> and call kfree(dev) in blktrans_dev_put to release the memory of
> mtd_blktrans_dev, so when ftl_freepart reclaims the memory of other
> member pointers of the partition_t, it will trigger the uaf problem,
> Fix it by moving ftl_freepart in front of del_mtd_blktrans_dev.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> drivers/mtd/ftl.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c
> index 200271bdc7aa..bec56070039d 100644
> --- a/drivers/mtd/ftl.c
> +++ b/drivers/mtd/ftl.c
> @@ -1039,8 +1039,12 @@ static void ftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
>
> static void ftl_remove_dev(struct mtd_blktrans_dev *dev)
> {
> + struct partition_t *partition;
> +
> + partition = container_of(dev, struct partition_t, mbd);
> +
> + ftl_freepart(partition);
> del_mtd_blktrans_dev(dev);
> - ftl_freepart((partition_t *)dev);
> }
>
> static struct mtd_blktrans_ops ftl_tr = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-18 1:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-15 7:11 [PATCH -next] mtd/ftl: Fix uaf in ftl_remove_dev() Gaosheng Cui
2022-08-18 1:32 ` cuigaosheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®