mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth
@ 2026-02-27  5:31 Zijun Hu
  2026-02-27 11:20 ` Krzysztof Kozlowski
  2026-02-27 12:20 ` Dmitry Baryshkov
  0 siblings, 2 replies; 7+ messages in thread
From: Zijun Hu @ 2026-02-27  5:31 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: Zijun Hu, linux-arm-msm, devicetree, linux-kernel, Zijun Hu

Enable bluetooth WCN785x on Glymur CRD.

Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur-crd.dts | 85 +++++++++++++++++++++++++++++++++
 1 file changed, 85 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts
index 877945319012..ffea5f757a86 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dts
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts
@@ -121,6 +121,65 @@ vreg_wwan: regulator-wwan {
 		pinctrl-0 = <&wwan_reg_en>;
 		pinctrl-names = "default";
 	};
+
+	wcn7850-pmu {
+		compatible = "qcom,wcn7850-pmu";
+
+		pinctrl-0 = <&bt_en_default>;
+		pinctrl-names = "default";
+
+		bt-enable-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>;
+
+		vdd-supply = <&vreg_wlan>;
+		vddio-supply = <&vreg_l15b_e0_1p8>;
+		vddio1p2-supply = <&vreg_l15b_e0_1p8>;
+		vddaon-supply = <&vreg_l15b_e0_1p8>;
+		vdddig-supply = <&vreg_l15b_e0_1p8>;
+		vddrfa1p2-supply = <&vreg_l15b_e0_1p8>;
+		vddrfa1p8-supply = <&vreg_l15b_e0_1p8>;
+
+		regulators {
+			vreg_pmu_rfa_cmn: ldo0 {
+				regulator-name = "vreg_pmu_rfa_cmn";
+			};
+
+			vreg_pmu_aon_0p59: ldo1 {
+				regulator-name = "vreg_pmu_aon_0p59";
+			};
+
+			vreg_pmu_wlcx_0p8: ldo2 {
+				regulator-name = "vreg_pmu_wlcx_0p8";
+			};
+
+			vreg_pmu_wlmx_0p85: ldo3 {
+				regulator-name = "vreg_pmu_wlmx_0p85";
+			};
+
+			vreg_pmu_btcmx_0p85: ldo4 {
+				regulator-name = "vreg_pmu_btcmx_0p85";
+			};
+
+			vreg_pmu_rfa_0p8: ldo5 {
+				regulator-name = "vreg_pmu_rfa_0p8";
+			};
+
+			vreg_pmu_rfa_1p2: ldo6 {
+				regulator-name = "vreg_pmu_rfa_1p2";
+			};
+
+			vreg_pmu_rfa_1p8: ldo7 {
+				regulator-name = "vreg_pmu_rfa_1p8";
+			};
+
+			vreg_pmu_pcie_0p9: ldo8 {
+				regulator-name = "vreg_pmu_pcie_0p9";
+			};
+
+			vreg_pmu_pcie_1p8: ldo9 {
+				regulator-name = "vreg_pmu_pcie_1p8";
+			};
+		};
+	};
 };
 
 &apps_rsc {
@@ -490,6 +549,14 @@ &tlmm {
 			       <10 2>, /* OOB UART */
 			       <44 4>; /* Security SPI (TPM) */
 
+	bt_en_default: bt-en-default-state {
+		pins = "gpio116";
+		function = "gpio";
+		drive-strength = <2>;
+		bias-disable;
+		output-low;
+	};
+
 	pcie4_default: pcie4-default-state {
 		clkreq-n-pins {
 			pins = "gpio147";
@@ -596,3 +663,21 @@ wwan_reg_en: wwan-reg-en-state {
 		bias-disable;
 	};
 };
+
+&uart14 {
+	status = "okay";
+
+	bluetooth {
+		compatible = "qcom,wcn7850-bt";
+
+		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+		vddaon-supply = <&vreg_pmu_aon_0p59>;
+		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+		vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>;
+
+		max-speed = <3200000>;
+	};
+};

---
base-commit: 85694946ded4155d81c70dcde58f828b3dc16372
change-id: 20260224-bt_glymur-6d44f2f1a85a

Best regards,
-- 
Zijun Hu <zijun.hu@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth
  2026-02-27  5:31 [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth Zijun Hu
@ 2026-02-27 11:20 ` Krzysztof Kozlowski
  2026-02-27 11:37   ` Zijun Hu
  2026-02-27 12:20 ` Dmitry Baryshkov
  1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-27 11:20 UTC (permalink / raw)
  To: Zijun Hu, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Zijun Hu, linux-arm-msm, devicetree, linux-kernel

On 27/02/2026 06:31, Zijun Hu wrote:
> Enable bluetooth WCN785x on Glymur CRD.
> 
> Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/glymur-crd.dts | 85 +++++++++++++++++++++++++++++++++
>  1 file changed, 85 insertions(+)

Why are you making concurrent work and sending something which was
prepared by Abel already?

https://git.codelinaro.org/clo/linux-kernel/kernel-qcom/-/commit/a0288828563bb1e2101ef8f1e782c8185c5757e6

This was ready 4 months ago, wasn't it?

Don't work in parallel and then send duplicated work. If your manager
told you this, ask them to stop and rethink their goals/tasks.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth
  2026-02-27 11:20 ` Krzysztof Kozlowski
@ 2026-02-27 11:37   ` Zijun Hu
  2026-02-27 11:43     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 7+ messages in thread
From: Zijun Hu @ 2026-02-27 11:37 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Zijun Hu, linux-arm-msm, devicetree, linux-kernel

On 2/27/2026 7:20 PM, Krzysztof Kozlowski wrote:
> Why are you making concurrent work and sending something which was
> prepared by Abel already?
> 
> https://git.codelinaro.org/clo/linux-kernel/kernel-qcom/-/commit/a0288828563bb1e2101ef8f1e782c8185c5757e6
> 
> This was ready 4 months ago, wasn't it?

yes.
the git repo is a private one, so nobody will notice and code review it if this change is not posted to https://lore.kernel.org.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth
  2026-02-27 11:37   ` Zijun Hu
@ 2026-02-27 11:43     ` Krzysztof Kozlowski
  2026-02-27 11:58       ` Zijun Hu
  0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-27 11:43 UTC (permalink / raw)
  To: Zijun Hu, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Zijun Hu, linux-arm-msm, devicetree, linux-kernel

On 27/02/2026 12:37, Zijun Hu wrote:
> On 2/27/2026 7:20 PM, Krzysztof Kozlowski wrote:
>> Why are you making concurrent work and sending something which was
>> prepared by Abel already?
>>
>> https://git.codelinaro.org/clo/linux-kernel/kernel-qcom/-/commit/a0288828563bb1e2101ef8f1e782c8185c5757e6
>>
>> This was ready 4 months ago, wasn't it?
> 
> yes.
> the git repo is a private one, so nobody will notice and code review it if this change is not posted to https://lore.kernel.org.

No, it is not true. The repo is public.

I am asking why are you duplicating the work, why you are asked even to
work on something which was already finished/prepared?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth
  2026-02-27 11:43     ` Krzysztof Kozlowski
@ 2026-02-27 11:58       ` Zijun Hu
  2026-02-27 13:17         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 7+ messages in thread
From: Zijun Hu @ 2026-02-27 11:58 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Zijun Hu, linux-arm-msm, devicetree, linux-kernel

On 2/27/2026 7:43 PM, Krzysztof Kozlowski wrote:
>> yes.
>> the git repo is a private one, so nobody will notice and code review it if this change is not posted to https://lore.kernel.org.
> No, it is not true. The repo is public.
>

The 'private' i mean is that the repo is not mentioned in kernel tree.
so it is not known by public.
> I am asking why are you duplicating the work, why you are asked even to
> work on something which was already finished/prepared?

actually, both i and many colleagues does not notice the change obviously.
so cause duplicated effort.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth
  2026-02-27  5:31 [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth Zijun Hu
  2026-02-27 11:20 ` Krzysztof Kozlowski
@ 2026-02-27 12:20 ` Dmitry Baryshkov
  1 sibling, 0 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2026-02-27 12:20 UTC (permalink / raw)
  To: Zijun Hu
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Zijun Hu, linux-arm-msm, devicetree, linux-kernel

On Thu, Feb 26, 2026 at 09:31:16PM -0800, Zijun Hu wrote:
> Enable bluetooth WCN785x on Glymur CRD.

Please enable the WiFi part too. They are two parts of the same chip.

> 
> Signed-off-by: Zijun Hu <zijun.hu@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/glymur-crd.dts | 85 +++++++++++++++++++++++++++++++++
>  1 file changed, 85 insertions(+)

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth
  2026-02-27 11:58       ` Zijun Hu
@ 2026-02-27 13:17         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-27 13:17 UTC (permalink / raw)
  To: Zijun Hu, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: Zijun Hu, linux-arm-msm, devicetree, linux-kernel

On 27/02/2026 12:58, Zijun Hu wrote:
> On 2/27/2026 7:43 PM, Krzysztof Kozlowski wrote:
>>> yes.
>>> the git repo is a private one, so nobody will notice and code review it if this change is not posted to https://lore.kernel.org.
>> No, it is not true. The repo is public.
>>
> 
> The 'private' i mean is that the repo is not mentioned in kernel tree.
> so it is not known by public.

Entire Qualcomm Glymur work was coordinated through that repo, so what
do you mean "it is not known"?

>> I am asking why are you duplicating the work, why you are asked even to
>> work on something which was already finished/prepared?
> 
> actually, both i and many colleagues does not notice the change obviously.
> so cause duplicated effort.

Then I think your team or colleagues or managers should look there first
or ask points of contact for Glymur upstreaming, so you will not be
doing same work again.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-02-27 13:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-27  5:31 [PATCH] arm64: dts: qcom: glymur-crd: Enable bluetooth Zijun Hu
2026-02-27 11:20 ` Krzysztof Kozlowski
2026-02-27 11:37   ` Zijun Hu
2026-02-27 11:43     ` Krzysztof Kozlowski
2026-02-27 11:58       ` Zijun Hu
2026-02-27 13:17         ` Krzysztof Kozlowski
2026-02-27 12:20 ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®