* Redundent Parameter or Inconsistent Hardcoding
@ 2006-12-15 16:08 Dong Feng
0 siblings, 0 replies; only message in thread
From: Dong Feng @ 2006-12-15 16:08 UTC (permalink / raw)
To: linux-kernel
Function permanent_kmaps_init() take a struct pgd_t as parameter.
I presume passing the struct pgd_t as a parameter is to make the
function flexible in order to reuse it under different cases. However,
I discover the following things imparing the rationality of this
parameter.
1. This function is invoke from one place only. That is, in
pagetable_init(), where swapper_pg_dir is passed as the parameter.
2. The function accesses swapper_pg_dir directly.
So I think either the parameter is redundent or the direct hardcoded
access to swapper_pg_dir within the function should be replaced by the
access to the parameter.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-12-15 16:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-15 16:08 Redundent Parameter or Inconsistent Hardcoding Dong Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®