From: Quentin Schulz <quentin.schulz@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: mark.rutland@arm.com, boris.brezillon@free-electrons.com,
alsa-devel@alsa-project.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mturquette@baylibre.com, tiwai@suse.com, sboyd@codeaurora.org,
lgirdwood@gmail.com, linux@armlinux.org.uk, robh+dt@kernel.org,
broonie@kernel.org, cyrille.pitchen@wedev4u.fr, perex@perex.cz,
thomas.petazzoni@free-electrons.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 0/9] add support for Sama5d2 audio PLLs and enable ClassD
Date: Wed, 26 Jul 2017 09:08:37 +0200 [thread overview]
Message-ID: <a2f50c1d-7889-8a62-a7d4-240d6310de15@free-electrons.com> (raw)
In-Reply-To: <20170726065732.zphp7zaug4ypcqzj@piout.net>
Hi Alexandre,
On 26/07/2017 08:57, Alexandre Belloni wrote:
> On 25/07/2017 at 17:44:19 +0200, Nicolas Ferre wrote:
>> On 25/07/2017 at 09:37, Quentin Schulz wrote:
>>> This patch series adds support for the audio PLLs and enables ClassD that
>>> can be found in ATMEL Sama5d2 SoC.
>>>
>>> There are two audio PLLs (PMC and PAD) that shares the same parent (FRAC).
>>> FRAC can output between 620 and 700MHz and only multiply the rate of its
>>> parent. The two audio PLLs then divide the FRAC rate to best match the
>>> asked rate.
>>>
>>> I basically took an old patch series posted by Nicolas on December, 6th
>>> 2016[1][2][3] and the comments Boris did on the first version[4] Nicolas
>>> sent on July, 15th 2015.
>>>
>>> I also fixed the function used to compute the divisors, removed useless
>>> spinlocks and added a range to the audio frac PLL to stay within vendor's
>>> supported range. Clocks that are children of gclk (generated-clk) are now
>>> able to propagate rate to the audio PLL clocks when needed.
>>>
>>> However, there are multiple children clocks that could technically
>>> change the rate of audio_pll (via gck). With the rate locking introduced
>>> in Jerome Brunet's patch series[5], the first consumer to enable the clock
>>> will be the one definitely setting the rate of the clock. Without the rate
>>> locking, the last consumer to set the rate will be able to mess with the
>>> rate.
>>> Since audio IPs are most likely to request the same rate, we enforce
>>> that the only clks able to modify gck rate are those of audio IPs.
>>>
>>> To remain consistent, we deny other clocks to be children of audio_pll.
>>
>> Quentin,
>>
>> Thanks for having revived this series. Everything's okay on my side for
>> this v4. I think that my tag isn't missing from any patch of this
>> series. Now we surely need to define which path it must take...
>>
>
> I'll take the two dts patches now as the bindings have been acked.
> Everything else should probably go through the clk tree.
>
Thanks for taking the dts patches.
I agree that the remaining should go through the clk tree. @Stephen,
@Michael, any objection (apart from your reviews on the patches) on
taking this through your tree?
Thanks,
Quentin
--
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-07-26 7:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 7:37 Quentin Schulz
2017-07-25 7:37 ` [PATCH v4 1/9] clk: at91: clk-generated: remove useless divisor loop Quentin Schulz
2017-07-25 15:28 ` Nicolas Ferre
2017-07-25 7:37 ` [PATCH v4 2/9] dt-bindings: clk: at91: add audio plls to the compatible list Quentin Schulz
2017-07-25 15:45 ` Nicolas Ferre
2017-07-25 7:37 ` [PATCH v4 3/9] clk: at91: add audio pll clock drivers Quentin Schulz
2017-07-25 7:37 ` [PATCH v4 4/9] ARM: dts: at91: sama5d2: add classd nodes Quentin Schulz
2017-07-26 6:59 ` Alexandre Belloni
2017-07-25 7:37 ` [PATCH v4 5/9] clk: at91: clk-generated: create function to find best_diff Quentin Schulz
2017-07-25 15:33 ` Nicolas Ferre
2017-07-25 7:37 ` [PATCH v4 6/9] clk: at91: clk-generated: make gclk determine audio_pll rate Quentin Schulz
2017-07-25 15:37 ` Nicolas Ferre
2017-07-25 7:37 ` [PATCH v4 7/9] ASoC: atmel-classd: remove aclk clock from DT binding Quentin Schulz
2017-07-25 15:38 ` Nicolas Ferre
2017-07-25 7:37 ` [PATCH v4 8/9] ASoC: atmel-classd: remove aclk clock Quentin Schulz
2017-07-25 15:40 ` Nicolas Ferre
2017-07-25 7:37 ` [PATCH v4 9/9] ARM: dts: at91: sama5d2_xplained: add pin muxing and enable classd Quentin Schulz
2017-07-26 6:59 ` Alexandre Belloni
2017-07-25 15:44 ` [PATCH v4 0/9] add support for Sama5d2 audio PLLs and enable ClassD Nicolas Ferre
2017-07-26 6:57 ` Alexandre Belloni
2017-07-26 7:08 ` Quentin Schulz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2f50c1d-7889-8a62-a7d4-240d6310de15@free-electrons.com \
--to=quentin.schulz@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®