From: "Andreas Färber" <afaerber@suse.de>
To: Jason Cooper <jason@lakedaemon.net>, Ansuel Smith <ansuelsmth@gmail.com>
Cc: gregory.clement@free-electrons.com, andrew@lunn.ch,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led
Date: Sun, 19 Feb 2017 01:01:36 +0100 [thread overview]
Message-ID: <a2fb4893-b890-3fa9-655c-fb0723d98048@suse.de> (raw)
In-Reply-To: <20170218141213.GK25924@io.lakedaemon.net>
Hi,
Am 18.02.2017 um 15:12 schrieb Jason Cooper:
> On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
>> In others board we have the sata led set to funcion with the sata led trigger by default.
>> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
>
> Please line wrap the commit message.
The subject could also use some love, like mentioning "ARM:" and
"armada" and dropping "Board". Compare git log --oneline.
Regards,
Andreas
> Other than that,
>
>>
>> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
>
> Acked-by: Jason Cooper <jason@lakedaemon.net>
>
> thx,
>
> Jason.
>
>> ---
>> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
>> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
>> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
>> 3 files changed, 3 insertions(+)
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2017-02-19 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 20:42 Ansuel Smith
2017-02-18 14:12 ` Jason Cooper
2017-02-19 0:01 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2fb4893-b890-3fa9-655c-fb0723d98048@suse.de \
--to=afaerber@suse.de \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®