Re: [PATCH 2/2] hwmon: (ina780) Add driver for TI INA780

[Guenter Roeck <linux@roeck-us.net>]

On 8/5/25 20:41, Chris Packham wrote:
> Hi Guenter,
> 
> On 06/08/2025 15:14, Guenter Roeck wrote:
>> On 8/5/25 17:51, Chris Packham wrote:
>>> Add support for the TI INA780 Digital Power Monitor.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>
>> Looking at the registers, the chip seems to be almost identical to
>> INA237/238.
>> Why a new driver ?
> 
> Yes I'd noticed the same thing as I went along. The INA780 has the
> ezshunt thing (not sure if that's the same as the internal shunt on the
> INA260) which means that a lot of the places where things are calculated
> by the shunt resistor value aren't applicable and there's one less
> voltage sensor. I did consider adding it to the ina2xx.c but it seemed
> different enough to those chips to warrant a separate driver.
> 
> I think I can kind of squint and see how I might fold the ina780 support
> into the ina238 driver although that may make things a bit messier. If
> that's the direction you'd like to head I can give it a go.

Compare against INA280. The only difference I can see is that there is no
shunt resistor register, and current/power/energy LSBs are constant instead
of being configurable. That should be quite straightforward to figure out.

Guenter