From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
jdelvare@suse.com, linux@roeck-us.net, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina780a: Add INA780 device
Date: Wed, 6 Aug 2025 08:32:38 +0200 [thread overview]
Message-ID: <f2972a86-f58d-4360-b43a-486377b101e1@kernel.org> (raw)
In-Reply-To: <20250806005127.542298-1-chris.packham@alliedtelesis.co.nz>
On 06/08/2025 02:51, Chris Packham wrote:
> +
> +properties:
> + compatible:
> + enum:
> + - ti,ina780a
> + - ti,ina780b
> +
> + reg:
> + maxItems: 1
This looks a bit incomplete. Where is a supply? No shunt resistor
choice? No other properties from ina2xx apply?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-06 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 0:51 Chris Packham
2025-08-06 0:51 ` [PATCH 2/2] hwmon: (ina780) Add driver for TI INA780 Chris Packham
2025-08-06 3:14 ` Guenter Roeck
2025-08-06 3:41 ` Chris Packham
2025-08-06 20:22 ` Guenter Roeck
2025-08-06 19:21 ` kernel test robot
2025-08-06 6:32 ` Krzysztof Kozlowski [this message]
2025-08-07 20:46 ` [PATCH 1/2] dt-bindings: hwmon: ti,ina780a: Add INA780 device Chris Packham
2025-08-08 7:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2972a86-f58d-4360-b43a-486377b101e1@kernel.org \
--to=krzk@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®