[PATCH] spi: atmel-quadspi: Fix register name in verbose logging function

[PATCH] spi: atmel-quadspi: Fix register name in verbose logging function

[Csókás, Bence]

`atmel_qspi_reg_name()` is used for pretty-printing register offsets
for verbose logging of register accesses. However, due to a typo
(likely a copy-paste error), QSPI_RD's offset prnts as "MR", the
name of the previous register. Fix this typo.

Fixes: c528ecfbef04 ("spi: atmel-quadspi: Add verbose debug facilities to monitor register accesses")
Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
---
 drivers/spi/atmel-quadspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
index 91108ddfaef2..316bce577081 100644
--- a/drivers/spi/atmel-quadspi.c
+++ b/drivers/spi/atmel-quadspi.c
@@ -183,7 +183,7 @@ static const char *atmel_qspi_reg_name(u32 offset, char *tmp, size_t sz)
 	case QSPI_MR:
 		return "MR";
 	case QSPI_RD:
-		return "MR";
+		return "RD";
 	case QSPI_TD:
 		return "TD";
 	case QSPI_SR:
-- 
2.34.1

Re: [PATCH] spi: atmel-quadspi: Fix register name in verbose logging function

[Alexander Dahl]

Hello,

Am Fri, Nov 22, 2024 at 03:13:02PM +0100 schrieb Csókás, Bence:
> `atmel_qspi_reg_name()` is used for pretty-printing register offsets
> for verbose logging of register accesses. However, due to a typo
> (likely a copy-paste error), QSPI_RD's offset prnts as "MR", the
> name of the previous register. Fix this typo.
> 
> Fixes: c528ecfbef04 ("spi: atmel-quadspi: Add verbose debug facilities to monitor register accesses")
> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
> ---
>  drivers/spi/atmel-quadspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> index 91108ddfaef2..316bce577081 100644
> --- a/drivers/spi/atmel-quadspi.c
> +++ b/drivers/spi/atmel-quadspi.c
> @@ -183,7 +183,7 @@ static const char *atmel_qspi_reg_name(u32 offset, char *tmp, size_t sz)
>  	case QSPI_MR:
>  		return "MR";
>  	case QSPI_RD:
> -		return "MR";
> +		return "RD";
>  	case QSPI_TD:
>  		return "TD";
>  	case QSPI_SR:

Reviewed-by: Alexander Dahl <ada@thorsis.com>

Greets
Alex

Re: [PATCH] spi: atmel-quadspi: Fix register name in verbose logging function

[Claudiu Beznea]

On 22.11.2024 16:13, Csókás, Bence wrote:
> `atmel_qspi_reg_name()` is used for pretty-printing register offsets
> for verbose logging of register accesses. However, due to a typo
> (likely a copy-paste error), QSPI_RD's offset prnts as "MR", the

s/prnts/prints ?

> name of the previous register. Fix this typo.

Re: [PATCH] spi: atmel-quadspi: Fix register name in verbose logging function

[Csókás Bence]

On 2024. 11. 22. 15:52, Claudiu Beznea wrote:
> 
> 
> On 22.11.2024 16:13, Csókás, Bence wrote:
>> `atmel_qspi_reg_name()` is used for pretty-printing register offsets
>> for verbose logging of register accesses. However, due to a typo
>> (likely a copy-paste error), QSPI_RD's offset prnts as "MR", the
> 
> s/prnts/prints ?

A typo in a commit msg fixing a typo, how ironic... I guess I should a) 
re-read my mail more carefully, and b) get my keyboard checked... It 
starts missing letters when I quick-type :/

Anyways, if you pick this up, feel free to amend. If there's a v2 (I 
doubt it'll be needed though), then I'll amend this as well obviously.
Bence

P.S. it missed an 'n' again, while composing this one. Ugh.

Re: [PATCH] spi: atmel-quadspi: Fix register name in verbose logging function

[Mark Brown]

On Fri, 22 Nov 2024 15:13:02 +0100, Csókás, Bence wrote:
> `atmel_qspi_reg_name()` is used for pretty-printing register offsets
> for verbose logging of register accesses. However, due to a typo
> (likely a copy-paste error), QSPI_RD's offset prnts as "MR", the
> name of the previous register. Fix this typo.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: atmel-quadspi: Fix register name in verbose logging function
      commit: 1c6f3eb4f394d8bb14b2b677151c347a0db088eb

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark