From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Joonhoe Kim <26rote@gmail.com>, mani@kernel.org, mkp@kernel.org
Cc: James.Bottomley@HansenPartnership.com, bvanassche@acm.org,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: qcom: Reprogram ESI after a host controller reset
Date: Fri, 23 Oct 2026 09:45:31 +0200 [thread overview]
Message-ID: <a3298437-21c9-4b91-94f0-417d92045afc@oss.qualcomm.com> (raw)
In-Reply-To: <20261022165006.1275-1-26rote@gmail.com>
On 10/22/26 6:50 PM, Joonhoe Kim wrote:
> ufs_qcom_config_esi() returns early once the ESI interrupts are set up.
> ufshcd_config_mcq() also calls it after every host controller reset,
> which clears the ESI base address, the vector mask and ESI enable. After
> the error handler has reset the controller, the completions then arrive
> only on the legacy interrupt while mcq_esi_enabled stays set.
>
> Allocate the MSIs and request their interrupts only once, but program
> the ESI registers on every call. The MSI message is not cached for
> platform MSIs, so keep the one written at allocation.
>
> Fixes: 519b6274a777 ("scsi: ufs: qcom: Add MCQ ESI config vendor specific ops")
> Signed-off-by: Joonhoe Kim <26rote@gmail.com>
> ---
I'm not sure it's related, but with this change, do you still need
https://lore.kernel.org/linux-arm-msm/20261007143716.2161-1-26rote@gmail.com/
?
Konrad
next prev parent reply other threads:[~2026-10-23 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 16:50 Joonhoe Kim
2026-10-23 7:45 ` Konrad Dybcio [this message]
2026-10-23 12:34 ` Joonhoe Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3298437-21c9-4b91-94f0-417d92045afc@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=26rote@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mkp@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®