Re: [PATCH] scsi: ufs: qcom: Reprogram ESI after a host controller reset

[Joonhoe Kim <26rote@gmail.com>]

On 10/23/26 9:45 AM, Konrad Dybcio wrote:
> I'm not sure it's related, but with this change, do you still need
>
> https://lore.kernel.org/linux-arm-msm/20261007143716.2161-1-26rote@gmail.com/
>
> ?

Yes, they fix different problems.

With MCQ enabled (which needs DT changes not yet upstream for
Kaanapali) and without FORCE_MEM_CORE_ON on the UFS PHY AXI clock, the
MCQ configuration is not retained over s2idle. The first command after
resume then triggers an SMMU fault and the error handler resets the
host; on my device that happened on almost every resume. With the clock
patch the configuration is retained, and I have not seen a reset over
s2idle since.

This patch is about any host reset, e.g. from the error handler after a
UIC error: the reset clears the ESI registers, and ufs_qcom_config_esi()
does not program them again, so completions fall back to the legacy
interrupt. It does nothing about the s2idle faults themselves.

Thanks,
Joonhoe Kim