From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>,
<alexandre.torgue@st.com>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 12/17] net: stmmac: rename rx_crc to rx_crc_errors
Date: Tue, 31 Jan 2017 11:08:19 +0100 [thread overview]
Message-ID: <a33f547e-9e8c-ca28-660c-47b361a107dc@st.com> (raw)
In-Reply-To: <20170131091152.13842-13-clabbe.montjoie@gmail.com>
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> The ethtool stat counter rx_crc from stmmac is mis-named, the name
> seems to speak about the number of RX CRC done, but in fact it is about
> errors.
>
> This patch rename it to rx_crc_errors, just like the same ifconfig
> counter.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/common.h | 2 +-
> drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h
> index 9da4877..b7ee15a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/common.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/common.h
> @@ -67,7 +67,7 @@ struct stmmac_extra_stats {
> unsigned long overflow_error;
> unsigned long ipc_csum_error;
> unsigned long rx_collision;
> - unsigned long rx_crc;
> + unsigned long rx_crc_errors;
> unsigned long dribbling_bit;
> unsigned long rx_length;
> unsigned long rx_mii;
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> index 8816515..843ec69 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> @@ -103,7 +103,7 @@ static int dwmac4_wrback_get_rx_status(void *data, struct stmmac_extra_stats *x,
> x->rx_mii++;
>
> if (unlikely(rdes3 & RDES3_CRC_ERROR)) {
> - x->rx_crc++;
> + x->rx_crc_errors++;
> stats->rx_crc_errors++;
> }
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/enh_desc.c b/drivers/net/ethernet/stmicro/stmmac/enh_desc.c
> index 8427643..323b59e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/enh_desc.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/enh_desc.c
> @@ -221,7 +221,7 @@ static int enh_desc_get_rx_status(void *data, struct stmmac_extra_stats *x,
> x->rx_mii++;
>
> if (unlikely(rdes0 & RDES0_CRC_ERROR)) {
> - x->rx_crc++;
> + x->rx_crc_errors++;
> stats->rx_crc_errors++;
> }
> ret = discard_frame;
> diff --git a/drivers/net/ethernet/stmicro/stmmac/norm_desc.c b/drivers/net/ethernet/stmicro/stmmac/norm_desc.c
> index 5a0d4b0..efb818e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/norm_desc.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/norm_desc.c
> @@ -111,7 +111,7 @@ static int ndesc_get_rx_status(void *data, struct stmmac_extra_stats *x,
> stats->collisions++;
> }
> if (unlikely(rdes0 & RDES0_CRC_ERROR)) {
> - x->rx_crc++;
> + x->rx_crc_errors++;
> stats->rx_crc_errors++;
> }
> ret = discard_frame;
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> index 69db8cb..6ca0a10 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> @@ -61,7 +61,7 @@ static const struct stmmac_stats stmmac_gstrings_stats[] = {
> STMMAC_STAT(overflow_error),
> STMMAC_STAT(ipc_csum_error),
> STMMAC_STAT(rx_collision),
> - STMMAC_STAT(rx_crc),
> + STMMAC_STAT(rx_crc_errors),
> STMMAC_STAT(dribbling_bit),
> STMMAC_STAT(rx_length),
> STMMAC_STAT(rx_mii),
>
next prev parent reply other threads:[~2017-01-31 10:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 9:11 [PATCH 00/17] net: stmmac: misc fix Corentin Labbe
2017-01-31 9:11 ` [PATCH 01/17] net: stmmac: fix the typo on MAC_RNABLE_RX Corentin Labbe
2017-01-31 10:03 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 02/17] net: stmmac: Remove the bus_setup function pointer Corentin Labbe
2017-01-31 10:02 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 03/17] net: stmmac: fix some typos in comments Corentin Labbe
2017-01-31 10:03 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 04/17] net: stmmac: remove freesoftware address Corentin Labbe
2017-01-31 9:11 ` [PATCH 05/17] net: stmmac: remplace asm/io.h by linux/io.h Corentin Labbe
2017-01-31 9:11 ` [PATCH 06/17] net: stmmac: fix some code style problem Corentin Labbe
2017-01-31 10:05 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 07/17] net: stmmac: replace stmmac_mdio_busy_wait by readl_poll_timeout Corentin Labbe
2017-01-31 10:13 ` Giuseppe CAVALLARO
2017-01-31 10:39 ` Corentin Labbe
2017-01-31 10:44 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 08/17] net: stmmac: Use readl_poll_timeout Corentin Labbe
2017-01-31 9:11 ` [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL Corentin Labbe
2017-01-31 10:06 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 10/17] net: stmmac: Correct the error message about invalid speed Corentin Labbe
2017-01-31 10:07 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 11/17] net: stmmac: Rewrite two test against NULL value Corentin Labbe
2017-01-31 10:07 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 12/17] net: stmmac: rename rx_crc to rx_crc_errors Corentin Labbe
2017-01-31 10:08 ` Giuseppe CAVALLARO [this message]
2017-01-31 9:11 ` [PATCH 13/17] net: stmmac: Implement NAPI for TX Corentin Labbe
2017-01-31 10:28 ` Giuseppe CAVALLARO
2017-01-31 13:38 ` Corentin Labbe
2017-02-01 4:12 ` David Miller
2017-02-03 13:41 ` Corentin Labbe
2017-02-03 15:15 ` David Miller
2017-02-03 15:58 ` Corentin Labbe
2017-01-31 9:11 ` [PATCH 14/17] net: stmmac: print phy information Corentin Labbe
2017-01-31 10:10 ` Giuseppe CAVALLARO
2017-02-03 13:16 ` Corentin Labbe
2017-01-31 9:11 ` [PATCH 15/17] net: stmmac: remove dead code in stmmac_tx_clean Corentin Labbe
2017-01-31 10:21 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 16/17] net: stmmac: remove unused variable in sysfs_display_ring Corentin Labbe
2017-01-31 10:11 ` Giuseppe CAVALLARO
2017-01-31 9:11 ` [PATCH 17/17] net: stmmac: replace unsigned by u32 Corentin Labbe
2017-01-31 10:12 ` Giuseppe CAVALLARO
2017-01-31 10:00 ` [PATCH 00/17] net: stmmac: misc fix Giuseppe CAVALLARO
2017-01-31 10:23 ` Joao Pinto
2017-01-31 10:33 ` Giuseppe CAVALLARO
2017-01-31 10:37 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a33f547e-9e8c-ca28-660c-47b361a107dc@st.com \
--to=peppe.cavallaro@st.com \
--cc=alexandre.torgue@st.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®