From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@suse.de>, Haozhong Zhang <haozhong.zhang@intel.com>
Cc: kvm@vger.kernel.org, rkrcmar@redhat.com,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Gleb Natapov <gleb@kernel.org>, Tony Luck <tony.luck@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v2 1/3] KVM: VMX: move msr_ia32_feature_control to vcpu_vmx
Date: Thu, 16 Jun 2016 13:57:08 +0200 [thread overview]
Message-ID: <a344c4f2-8266-71f7-7574-9b54138155e6@redhat.com> (raw)
In-Reply-To: <20160616114916.GA20058@pd.tnic>
On 16/06/2016 13:49, Borislav Petkov wrote:
>> > enum segment_cache_field {
>> > @@ -2907,7 +2908,7 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>> > case MSR_IA32_FEATURE_CONTROL:
>> > if (!nested_vmx_allowed(vcpu))
>> > return 1;
>> > - msr_info->data = to_vmx(vcpu)->nested.msr_ia32_feature_control;
>> > + msr_info->data = to_vmx(vcpu)->msr_ia32_feature_control;
> Since this moves out of struct nested_vmx, that check above it:
>
> if (!nested_vmx_allowed(vcpu))
>
> should not influence it anymore, no?
For get, yes, this "if" should go.
For set, you need to check that the guest doesn't write to reserved
bits. So as of this patch the "if" remains tied to VMX, but the next
patch changes it to be generic.
Paolo
> Ditto for the rest.
next prev parent reply other threads:[~2016-06-16 11:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 6:05 [PATCH v2 0/3] Add KVM support for Intel local MCE Haozhong Zhang
2016-06-16 6:05 ` [PATCH v2 1/3] KVM: VMX: move msr_ia32_feature_control to vcpu_vmx Haozhong Zhang
2016-06-16 11:49 ` Borislav Petkov
2016-06-16 11:57 ` Paolo Bonzini [this message]
2016-06-16 11:57 ` Haozhong Zhang
2016-06-16 6:05 ` [PATCH v2 2/3] KVM: VMX: validate individual bits of guest MSR_IA32_FEATURE_CONTROL Haozhong Zhang
2016-06-16 9:55 ` Paolo Bonzini
2016-06-16 11:21 ` Haozhong Zhang
2016-06-16 10:01 ` Paolo Bonzini
2016-06-16 11:16 ` Haozhong Zhang
2016-06-16 11:19 ` Paolo Bonzini
2016-06-16 11:29 ` Haozhong Zhang
2016-06-16 6:05 ` [PATCH v2 3/3] KVM: VMX: enable guest access to LMCE related MSRs Haozhong Zhang
2016-06-16 10:04 ` Paolo Bonzini
2016-06-16 10:49 ` Haozhong Zhang
2016-06-16 14:55 ` Eduardo Habkost
2016-06-17 1:11 ` Haozhong Zhang
2016-06-17 17:15 ` Eduardo Habkost
2016-06-20 1:49 ` Haozhong Zhang
2016-06-20 6:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a344c4f2-8266-71f7-7574-9b54138155e6@redhat.com \
--to=pbonzini@redhat.com \
--cc=andi.kleen@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@suse.de \
--cc=gleb@kernel.org \
--cc=haozhong.zhang@intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®