* [PATCH] FUTEX: one more return .
@ 2006-02-16 17:42 Daniel Walker
2006-02-16 18:11 ` Ulrich Drepper
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Walker @ 2006-02-16 17:42 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel
Signed-Off-By: Daniel Walker <dwalker@mvista.com>
Continue the theme of returns .
Index: linux-2.6.15/kernel/futex.c
===================================================================
--- linux-2.6.15.orig/kernel/futex.c
+++ linux-2.6.15/kernel/futex.c
@@ -973,8 +973,10 @@ void exit_robust_list(struct task_struct
*/
if (get_user(pending, &head->list_op_pending))
return;
- if (pending)
- handle_futex_death((void *)pending + futex_offset, curr);
+ if (pending) {
+ if (handle_futex_death((void *)pending + futex_offset, curr))
+ return;
+ }
while (entry != &head->list) {
/*
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] FUTEX: one more return .
2006-02-16 17:42 [PATCH] FUTEX: one more return Daniel Walker
@ 2006-02-16 18:11 ` Ulrich Drepper
2006-02-16 19:15 ` Daniel Walker
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Drepper @ 2006-02-16 18:11 UTC (permalink / raw)
To: Daniel Walker; +Cc: mingo, linux-kernel
On 2/16/06, Daniel Walker <dwalker@mvista.com> wrote:
> Continue the theme of returns .
No, that's wrong. I got Ingo to remove this code and he documented it:
=====
- race fix: do not bail out in the list walk when the list_op_pending
pointer cannot be followed by the kernel - another userspace thread
may have already destroyed the mutex (and unmapped it), before this
thread had a chance to clear the field.
=====
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] FUTEX: one more return .
2006-02-16 18:11 ` Ulrich Drepper
@ 2006-02-16 19:15 ` Daniel Walker
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Walker @ 2006-02-16 19:15 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: mingo, linux-kernel
Ok ..
On Thu, 16 Feb 2006, Ulrich Drepper wrote:
> On 2/16/06, Daniel Walker <dwalker@mvista.com> wrote:
>> Continue the theme of returns .
>
> No, that's wrong. I got Ingo to remove this code and he documented it:
>
> =====
> - race fix: do not bail out in the list walk when the list_op_pending
> pointer cannot be followed by the kernel - another userspace thread
> may have already destroyed the mutex (and unmapped it), before this
> thread had a chance to clear the field.
> =====
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-16 19:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-16 17:42 [PATCH] FUTEX: one more return Daniel Walker
2006-02-16 18:11 ` Ulrich Drepper
2006-02-16 19:15 ` Daniel Walker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®