mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: kr494167@gmail.com, wim@linux-watchdog.org, cl634@andestech.com
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: atcwdt200: fix return value when watchdog is enabled
Date: Wed, 22 Jul 2026 22:12:06 -0700	[thread overview]
Message-ID: <a3660418-97af-4085-ba2d-8488eed1fd23@roeck-us.net> (raw)
In-Reply-To: <20260723022634.8642-1-kr494167@gmail.com>

On 7/22/26 19:26, kr494167@gmail.com wrote:
> From: Surendra Singh Chouhan <kr494167@gmail.com>
> 
> atcwdt_get_int_timer_type() returned TMR_UNKNOWN (enum value 3) when
> CTRL_WDT_EN was set in the control register.
> 
> Because atcwdt_probe() checks "ret = atcwdt_get_int_timer_type(drv_data);
> if (ret) return ret;", returning TMR_UNKNOWN caused probe() to return 3
> instead of a valid negative error code.
> 
> Fix this by returning -EBUSY via dev_err_probe() when the watchdog is
> already enabled and update the kernel-doc description accordingly.
> 
> Fixes: e4e0848ad046 ("watchdog: atcwdt200: Add driver for Andes ATCWDT200")
> Signed-off-by: Surendra Singh Chouhan <kr494167@gmail.com>
> ---]

Change log goes here. Do you really expect me to look up the patch history
to figure out what changed from v1 ?

Sure, this one was recent enough that I happen to remember, but
I seriously fail to understand why people can't be bothered to
add a couple of lines here to explain the changes they made.

Guenter

>   drivers/watchdog/atcwdt200_wdt.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/atcwdt200_wdt.c b/drivers/watchdog/atcwdt200_wdt.c
> index 8e3b18aea368..7e757c217b0b 100644
> --- a/drivers/watchdog/atcwdt200_wdt.c
> +++ b/drivers/watchdog/atcwdt200_wdt.c
> @@ -260,9 +260,9 @@ static void atcwdt_get_timeout_params(struct atcwdt_drv *drv_data,
>    * register to determine the interrupt timer type supported by the hardware.
>    *
>    * Note: This function must only be called when the ATCWDT200 watchdog is
> - * disabled. If the watchdog is enabled, this function returns TMR_UNKNOWN.
> + * disabled. If the watchdog is enabled, this function returns -EBUSY.
>    *
> - * Returns: The interrupt timer type supported by the hardware.
> + * Returns: 0 on success or negative error code on failure.
>    */
>   static int atcwdt_get_int_timer_type(struct atcwdt_drv *drv_data)
>   {
> @@ -274,7 +274,8 @@ static int atcwdt_get_int_timer_type(struct atcwdt_drv *drv_data)
>   	regmap_read(drv_data->regmap, REG_CTRL, &val);
>   	if (val & CTRL_WDT_EN) {
>   		spin_unlock(&drv_data->lock);
> -		return TMR_UNKNOWN;
> +		return dev_err_probe(dev, -EBUSY,
> +				     "Watchdog is enabled, cannot detect timer type\n");
>   	}
>   
>   	/*


  reply	other threads:[~2026-07-23  5:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  2:26 kr494167
2026-07-23  5:12 ` Guenter Roeck [this message]
2026-07-23 23:01 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3660418-97af-4085-ba2d-8488eed1fd23@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=cl634@andestech.com \
    --cc=kr494167@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®