From: Guenter Roeck <linux@roeck-us.net>
To: kr494167@gmail.com
Cc: wim@linux-watchdog.org, cl634@andestech.com,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: atcwdt200: fix return value when watchdog is enabled
Date: Thu, 23 Jul 2026 16:01:03 -0700 [thread overview]
Message-ID: <ef58b0e0-e397-4cc3-bac8-bb2e2f5253db@roeck-us.net> (raw)
In-Reply-To: <20260723022634.8642-1-kr494167@gmail.com>
On Thu, Jul 23, 2026 at 07:56:34AM +0530, kr494167@gmail.com wrote:
> From: Surendra Singh Chouhan <kr494167@gmail.com>
>
> atcwdt_get_int_timer_type() returned TMR_UNKNOWN (enum value 3) when
> CTRL_WDT_EN was set in the control register.
>
> Because atcwdt_probe() checks "ret = atcwdt_get_int_timer_type(drv_data);
> if (ret) return ret;", returning TMR_UNKNOWN caused probe() to return 3
> instead of a valid negative error code.
>
> Fix this by returning -EBUSY via dev_err_probe() when the watchdog is
> already enabled and update the kernel-doc description accordingly.
>
> Fixes: e4e0848ad046 ("watchdog: atcwdt200: Add driver for Andes ATCWDT200")
> Signed-off-by: Surendra Singh Chouhan <kr494167@gmail.com>
Applied. Next time please provide a change log.
Guenter
prev parent reply other threads:[~2026-07-23 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 2:26 kr494167
2026-07-23 5:12 ` Guenter Roeck
2026-07-23 23:01 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef58b0e0-e397-4cc3-bac8-bb2e2f5253db@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cl634@andestech.com \
--cc=kr494167@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®