Re: [PATCH] block/rnbd: Adding name to the Contributors List

Re: [PATCH] block/rnbd: Adding name to the Contributors List

[Jinpu Wang]

On Fri, Nov 27, 2020 at 1:31 PM Swapnil Ingle <ingleswapnil@gmail.com> wrote:
>
> Adding name to the Contributors List
>
> Signed-off-by: Swapnil Ingle <ingleswapnil@gmail.com>
Hi, Swapnil,

Thanks for your past contributions, sorry for missing your name on the list.
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
>  drivers/block/rnbd/README | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rnbd/README b/drivers/block/rnbd/README
> index 1773c0a..080f58a 100644
> --- a/drivers/block/rnbd/README
> +++ b/drivers/block/rnbd/README
> @@ -90,3 +90,4 @@ Kleber Souza <kleber.souza@profitbricks.com>
>  Lutz Pogrell <lutz.pogrell@cloud.ionos.com>
>  Milind Dumbare <Milind.dumbare@gmail.com>
>  Roman Penyaev <roman.penyaev@profitbricks.com>
> +Swapnil Ingle <ingleswapnil@gmail.com>
> --
> 1.8.3.1
>

Re: [PATCH] block/rnbd: Adding name to the Contributors List

[Danil Kipnis]

On Fri, Nov 27, 2020 at 1:31 PM Swapnil Ingle <ingleswapnil@gmail.com> wrote:
>
> Adding name to the Contributors List
>
> Signed-off-by: Swapnil Ingle <ingleswapnil@gmail.com>

Acked-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>

> ---
>  drivers/block/rnbd/README | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rnbd/README b/drivers/block/rnbd/README
> index 1773c0a..080f58a 100644
> --- a/drivers/block/rnbd/README
> +++ b/drivers/block/rnbd/README
> @@ -90,3 +90,4 @@ Kleber Souza <kleber.souza@profitbricks.com>
>  Lutz Pogrell <lutz.pogrell@cloud.ionos.com>
>  Milind Dumbare <Milind.dumbare@gmail.com>
>  Roman Penyaev <roman.penyaev@profitbricks.com>
> +Swapnil Ingle <ingleswapnil@gmail.com>
> --
> 1.8.3.1
>

Re: [PATCH] block/rnbd: Adding name to the Contributors List

[Jinpu Wang]

Hi Jens,

On Thu, Dec 17, 2020 at 6:44 PM swapnil ingle <ingleswapnil@gmail.com> wrote:
>
> Adding linux-rdma@vger.kernel.org
>
> On Fri, Nov 27, 2020 at 1:54 PM Danil Kipnis <danil.kipnis@cloud.ionos.com> wrote:
>>
>> On Fri, Nov 27, 2020 at 1:31 PM Swapnil Ingle <ingleswapnil@gmail.com> wrote:
>> >
>> > Adding name to the Contributors List
>> >
>> > Signed-off-by: Swapnil Ingle <ingleswapnil@gmail.com>
>>
>> Acked-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
Can you pick up this patch, or do you need a resend from me or Swapnil?

Thanks!
Jack
>>
>> > ---
>> >  drivers/block/rnbd/README | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/block/rnbd/README b/drivers/block/rnbd/README
>> > index 1773c0a..080f58a 100644
>> > --- a/drivers/block/rnbd/README
>> > +++ b/drivers/block/rnbd/README
>> > @@ -90,3 +90,4 @@ Kleber Souza <kleber.souza@profitbricks.com>
>> >  Lutz Pogrell <lutz.pogrell@cloud.ionos.com>
>> >  Milind Dumbare <Milind.dumbare@gmail.com>
>> >  Roman Penyaev <roman.penyaev@profitbricks.com>
>> > +Swapnil Ingle <ingleswapnil@gmail.com>
>> > --
>> > 1.8.3.1
>> >

Re: [PATCH] block/rnbd: Adding name to the Contributors List

[Jens Axboe]

On 12/17/20 11:46 PM, Jinpu Wang wrote:
> Hi Jens,
> 
> On Thu, Dec 17, 2020 at 6:44 PM swapnil ingle <ingleswapnil@gmail.com> wrote:
>>
>> Adding linux-rdma@vger.kernel.org
>>
>> On Fri, Nov 27, 2020 at 1:54 PM Danil Kipnis <danil.kipnis@cloud.ionos.com> wrote:
>>>
>>> On Fri, Nov 27, 2020 at 1:31 PM Swapnil Ingle <ingleswapnil@gmail.com> wrote:
>>>>
>>>> Adding name to the Contributors List
>>>>
>>>> Signed-off-by: Swapnil Ingle <ingleswapnil@gmail.com>
>>>
>>> Acked-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
> Can you pick up this patch, or do you need a resend from me or Swapnil?

Just include as part of the next series of patches. Though I do question
why we need such a contributors list to begin with, if you do git log on
the rnbd/ directory it'd show you anyway.

I'd also suggest moving the parts of the README that makes sense into a
proper Documentation/ file, nobody is going to find it deep in the
kernel source tree as it is.

-- 
Jens Axboe

Re: [PATCH] block/rnbd: Adding name to the Contributors List

[Jinpu Wang]

Hi, Jens
On Fri, Dec 18, 2020 at 3:53 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 12/17/20 11:46 PM, Jinpu Wang wrote:
> > Hi Jens,
> >
> > On Thu, Dec 17, 2020 at 6:44 PM swapnil ingle <ingleswapnil@gmail.com> wrote:
> >>
> >> Adding linux-rdma@vger.kernel.org
> >>
> >> On Fri, Nov 27, 2020 at 1:54 PM Danil Kipnis <danil.kipnis@cloud.ionos.com> wrote:
> >>>
> >>> On Fri, Nov 27, 2020 at 1:31 PM Swapnil Ingle <ingleswapnil@gmail.com> wrote:
> >>>>
> >>>> Adding name to the Contributors List
> >>>>
> >>>> Signed-off-by: Swapnil Ingle <ingleswapnil@gmail.com>
> >>>
> >>> Acked-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
> > Can you pick up this patch, or do you need a resend from me or Swapnil?
>
> Just include as part of the next series of patches. Though I do question
> why we need such a contributors list to begin with, if you do git log on
> the rnbd/ directory it'd show you anyway.
Thanks for the suggestion, we will include it as part of next series.
The initial reason to have such contributors list was to give credit
to people who worked on
the project in the past, Swapnil's name was missed.
>
> I'd also suggest moving the parts of the README that makes sense into a
> proper Documentation/ file, nobody is going to find it deep in the
> kernel source tree as it is.
Sounds good, will do it.
>
> --
> Jens Axboe
>
Thanks
Jack