From: Jani Nikula <jani.nikula@linux.intel.com>
To: syyang <syyang@lontium.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org
Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
yangsunyun1993@gmail.com, syyang <syyang@lontium.com>
Subject: Re: [PATCH v1 2/2] This patch adds a new DRM bridge driver for the Lontium LT9611C chip.
Date: Mon, 08 Sep 2025 14:07:38 +0300 [thread overview]
Message-ID: <a38fac371861f8651079d56f703826651f1568e1@intel.com> (raw)
In-Reply-To: <20250903123825.1721443-3-syyang@lontium.com>
On Wed, 03 Sep 2025, syyang <syyang@lontium.com> wrote:
> +static int i2c_write_byte(struct lt9611c *lt9611c, u8 reg, u8 val)
> +static int i2c_read_byte(struct lt9611c *lt9611c, u8 reg, u8 *val)
> +static int i2c_read_write_flow(struct lt9611c *lt9611c, u8 *params,
> + unsigned int param_count, u8 *return_buffer,
> + unsigned int return_count)
include/linux/i2c.h provides a plethora of i2c_ prefixed functions and
types. I think it's bad practice to reuse the prefix of a very common
kernel interface, even if in static functions.
You might get collisions later, but the reader of the code is mislead to
believe this is something in i2c.h.
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2025-09-08 11:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 12:38 [PATCH v1 0/2] Add LT9611C DRM bridge driver and device tree binding syyang
2025-09-03 12:38 ` [PATCH v1 1/2] This patch adds a new device tree binding documentation syyang
2025-09-03 16:33 ` Rob Herring (Arm)
2025-09-04 2:25 ` [PATCH v2 " syyang
2025-09-04 2:53 ` Dmitry Baryshkov
2025-09-04 5:49 ` Krzysztof Kozlowski
2025-09-04 8:08 ` 杨孙运
2025-09-04 8:26 ` Krzysztof Kozlowski
2025-09-04 11:27 ` 杨孙运
2025-09-04 2:21 ` [PATCH v1 " Dmitry Baryshkov
[not found] ` <CAFQXuNYKcGHyWLD5hjj24CrbaXzkaKsLU4R2vmhYaryQArA_yQ@mail.gmail.com>
2025-09-04 2:56 ` Dmitry Baryshkov
2025-09-03 12:38 ` [PATCH v1 2/2] This patch adds a new DRM bridge driver for the Lontium LT9611C chip syyang
2025-09-04 2:52 ` Dmitry Baryshkov
2025-09-04 10:48 ` 杨孙运
2025-09-04 11:04 ` Krzysztof Kozlowski
2025-09-04 11:17 ` 杨孙运
2025-09-04 14:39 ` Dmitry Baryshkov
2025-09-05 2:55 ` 杨孙运
2025-09-05 8:10 ` neil.armstrong
2025-09-05 8:58 ` 杨孙运
2025-09-05 14:24 ` Dmitry Baryshkov
2025-09-08 1:14 ` 杨孙运
2025-09-08 10:17 ` Dmitry Baryshkov
2025-09-05 14:10 ` Dmitry Baryshkov
2025-09-08 11:03 ` Jani Nikula
2025-09-08 11:07 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a38fac371861f8651079d56f703826651f1568e1@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=syyang@lontium.com \
--cc=yangsunyun1993@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®