From: Corey Minyard <minyard@acm.org>
To: David Binderman <dcb314@hotmail.com>,
"openipmi-developer@lists.sourceforge.net"
<openipmi-developer@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282: bad if condition ?
Date: Mon, 27 Nov 2017 08:22:07 -0600 [thread overview]
Message-ID: <a3a67d43-3169-a067-7caf-349b9b1e2dba@acm.org> (raw)
In-Reply-To: <HE1PR0802MB2331208F1E75AE58084669829C250@HE1PR0802MB2331.eurprd08.prod.outlook.com>
On 11/27/2017 06:32 AM, David Binderman wrote:
> Hello there,
>
> linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282]: (style) Expression is always false because 'else if' condition matches previous condition at line 2279
>
> Source code is
>
> if (new_smi->pdev) {
> platform_device_unregister(new_smi->pdev);
> new_smi->pdev = NULL;
> } else if (new_smi->pdev) {
>
> Suggest code rework.
Yeah, definitely wrong, fix is queues for next release. Thanks.
-corey
>
> Regards
>
> David Binderman
parent reply other threads:[~2017-11-27 14:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <HE1PR0802MB2331208F1E75AE58084669829C250@HE1PR0802MB2331.eurprd08.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3a67d43-3169-a067-7caf-349b9b1e2dba@acm.org \
--to=minyard@acm.org \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®