* Re: linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282: bad if condition ? [not found] <HE1PR0802MB2331208F1E75AE58084669829C250@HE1PR0802MB2331.eurprd08.prod.outlook.com> @ 2017-11-27 14:22 ` Corey Minyard 0 siblings, 0 replies; only message in thread From: Corey Minyard @ 2017-11-27 14:22 UTC (permalink / raw) To: David Binderman, openipmi-developer, linux-kernel On 11/27/2017 06:32 AM, David Binderman wrote: > Hello there, > > linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282]: (style) Expression is always false because 'else if' condition matches previous condition at line 2279 > > Source code is > > if (new_smi->pdev) { > platform_device_unregister(new_smi->pdev); > new_smi->pdev = NULL; > } else if (new_smi->pdev) { > > Suggest code rework. Yeah, definitely wrong, fix is queues for next release. Thanks. -corey > > Regards > > David Binderman ^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-11-27 14:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <HE1PR0802MB2331208F1E75AE58084669829C250@HE1PR0802MB2331.eurprd08.prod.outlook.com>
2017-11-27 14:22 ` linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282: bad if condition ? Corey Minyard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®