From: "André Draszik" <andre.draszik@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Peter Griffin <peter.griffin@linaro.org>,
Srinivas Kandagatla <srini@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
semen.protsenko@linaro.org, willmcvicker@google.com,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/5] soc: samsung: exynos-chipid: add google,gs101-otp support
Date: Tue, 23 Dec 2025 11:23:56 +0000 [thread overview]
Message-ID: <a3b89ce1a88e9efb2ff6af27bd1bd48dbc06c2fc.camel@linaro.org> (raw)
In-Reply-To: <aa55c3865d151697120a2855e711d59468bdcd0a.camel@linaro.org>
On Tue, 2025-12-23 at 10:18 +0000, André Draszik wrote:
> Looking closer, why is this not val? Now you're shifting the sub_rev
> register value by the main rev shift, assigning the sub_rev register
> value to the main rev variable.
>
> And then, all assignments to main_rev become identical and don't need to
> be duplicated.
Anyway, it does work for the SoCs supported, my RB still applies. Code can be
updated in the future if the need arises.
Cheers,
Andre'
next prev parent reply other threads:[~2025-12-23 11:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 16:30 [PATCH v4 0/5] soc: samsung: exynos-chipid: add gs101 support Tudor Ambarus
2025-12-22 16:30 ` [PATCH v4 1/5] dt-bindings: nvmem: add google,gs101-otp Tudor Ambarus
2025-12-22 16:30 ` [PATCH v4 2/5] soc: samsung: exynos-chipid: rename method Tudor Ambarus
2025-12-23 9:55 ` André Draszik
2025-12-23 10:14 ` Tudor Ambarus
2025-12-22 16:30 ` [PATCH v4 3/5] soc: samsung: exynos-chipid: downgrade dev_info to dev_dbg for soc info Tudor Ambarus
2025-12-22 16:30 ` [PATCH v4 4/5] soc: samsung: exynos-chipid: add google,gs101-otp support Tudor Ambarus
2025-12-23 9:56 ` André Draszik
2025-12-23 10:18 ` André Draszik
2025-12-23 11:23 ` André Draszik [this message]
2025-12-22 16:30 ` [PATCH v4 5/5] arm64: dts: exynos: gs101: add OTP node Tudor Ambarus
2025-12-23 10:01 ` André Draszik
2025-12-28 11:32 ` (subset) [PATCH v4 0/5] soc: samsung: exynos-chipid: add gs101 support Krzysztof Kozlowski
2025-12-28 11:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3b89ce1a88e9efb2ff6af27bd1bd48dbc06c2fc.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=srini@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®