mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* w1_therm should not unlock bus if strong pullup is forced
@ 2017-06-06  2:27 Ingo Flaschberger
  0 siblings, 0 replies; only message in thread
From: Ingo Flaschberger @ 2017-06-06  2:27 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

Hi,

If strong pullup is forced (=2) a strong pullup is placed for 750ms.
Is also external power detected the bus will be unlocked and a 
additional 750ms sleep is performed.
This 2nd sleep should be avoided.

Kind regards,
     Ingo Flaschberger



[-- Attachment #2: w1_therm.diff --]
[-- Type: text/plain, Size: 549 bytes --]

--- w1_therm.c_org	2017-06-06 04:05:48.028105363 +0200
+++ w1_therm.c	2017-06-06 04:05:36.883914878 +0200
@@ -245,7 +245,7 @@
 
 			w1_write_8(dev, W1_COPY_SCRATCHPAD);
 
-			if (external_power) {
+			if (external_power && w1_strong_pullup != 2) {
 				mutex_unlock(&dev->bus_mutex);
 
 				sleep_rem = msleep_interruptible(tm);
@@ -473,7 +473,7 @@
 
 			w1_write_8(dev, W1_CONVERT_TEMP);
 
-			if (external_power) {
+			if (external_power && w1_strong_pullup != 2) {
 				mutex_unlock(&dev->bus_mutex);
 
 				sleep_rem = msleep_interruptible(tm);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-06  2:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-06  2:27 w1_therm should not unlock bus if strong pullup is forced Ingo Flaschberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®