* [PATCH] spmi: add missing MODULE_DESCRIPTION() macros
@ 2024-06-10 0:40 Jeff Johnson
2024-06-26 16:15 ` Jeff Johnson
2024-07-18 21:02 ` Stephen Boyd
0 siblings, 2 replies; 5+ messages in thread
From: Jeff Johnson @ 2024-06-10 0:40 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Stephen Boyd
Cc: linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/hisi-spmi-controller.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/spmi-pmic-arb.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/spmi/hisi-spmi-controller.c | 1 +
drivers/spmi/spmi-pmic-arb.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
index fa068b34b040..3cafdf22c909 100644
--- a/drivers/spmi/hisi-spmi-controller.c
+++ b/drivers/spmi/hisi-spmi-controller.c
@@ -344,6 +344,7 @@ static void __exit spmi_controller_exit(void)
}
module_exit(spmi_controller_exit);
+MODULE_DESCRIPTION("Hisilicon 3670 SPMI Controller driver");
MODULE_LICENSE("GPL v2");
MODULE_VERSION("1.0");
MODULE_ALIAS("platform:spmi_controller");
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 791cdc160c51..f240fcc5a4e1 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -1891,5 +1891,6 @@ static struct platform_driver spmi_pmic_arb_driver = {
};
module_platform_driver(spmi_pmic_arb_driver);
+MODULE_DESCRIPTION("Qualcomm MSM SPMI Controller (PMIC Arbiter) driver");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:spmi_pmic_arb");
---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240609-md-drivers-spmi-51a13baa2301
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] spmi: add missing MODULE_DESCRIPTION() macros
2024-06-10 0:40 [PATCH] spmi: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-26 16:15 ` Jeff Johnson
2024-07-11 18:09 ` Jeff Johnson
2024-07-18 21:02 ` Stephen Boyd
1 sibling, 1 reply; 5+ messages in thread
From: Jeff Johnson @ 2024-06-26 16:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Stephen Boyd; +Cc: linux-kernel, kernel-janitors
On 6/9/2024 5:40 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/hisi-spmi-controller.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/spmi-pmic-arb.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/spmi/hisi-spmi-controller.c | 1 +
> drivers/spmi/spmi-pmic-arb.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
> index fa068b34b040..3cafdf22c909 100644
> --- a/drivers/spmi/hisi-spmi-controller.c
> +++ b/drivers/spmi/hisi-spmi-controller.c
> @@ -344,6 +344,7 @@ static void __exit spmi_controller_exit(void)
> }
> module_exit(spmi_controller_exit);
>
> +MODULE_DESCRIPTION("Hisilicon 3670 SPMI Controller driver");
> MODULE_LICENSE("GPL v2");
> MODULE_VERSION("1.0");
> MODULE_ALIAS("platform:spmi_controller");
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index 791cdc160c51..f240fcc5a4e1 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -1891,5 +1891,6 @@ static struct platform_driver spmi_pmic_arb_driver = {
> };
> module_platform_driver(spmi_pmic_arb_driver);
>
> +MODULE_DESCRIPTION("Qualcomm MSM SPMI Controller (PMIC Arbiter) driver");
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:spmi_pmic_arb");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240609-md-drivers-spmi-51a13baa2301
Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)
/jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] spmi: add missing MODULE_DESCRIPTION() macros
2024-06-26 16:15 ` Jeff Johnson
@ 2024-07-11 18:09 ` Jeff Johnson
2024-07-17 15:23 ` Stephen Boyd
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Johnson @ 2024-07-11 18:09 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Stephen Boyd, Greg Kroah-Hartman
Cc: linux-kernel, kernel-janitors
On 6/26/24 09:15, Jeff Johnson wrote:
> On 6/9/2024 5:40 PM, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/hisi-spmi-controller.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/spmi-pmic-arb.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> drivers/spmi/hisi-spmi-controller.c | 1 +
>> drivers/spmi/spmi-pmic-arb.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c
>> index fa068b34b040..3cafdf22c909 100644
>> --- a/drivers/spmi/hisi-spmi-controller.c
>> +++ b/drivers/spmi/hisi-spmi-controller.c
>> @@ -344,6 +344,7 @@ static void __exit spmi_controller_exit(void)
>> }
>> module_exit(spmi_controller_exit);
>>
>> +MODULE_DESCRIPTION("Hisilicon 3670 SPMI Controller driver");
>> MODULE_LICENSE("GPL v2");
>> MODULE_VERSION("1.0");
>> MODULE_ALIAS("platform:spmi_controller");
>> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
>> index 791cdc160c51..f240fcc5a4e1 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -1891,5 +1891,6 @@ static struct platform_driver spmi_pmic_arb_driver = {
>> };
>> module_platform_driver(spmi_pmic_arb_driver);
>>
>> +MODULE_DESCRIPTION("Qualcomm MSM SPMI Controller (PMIC Arbiter) driver");
>> MODULE_LICENSE("GPL v2");
>> MODULE_ALIAS("platform:spmi_pmic_arb");
>>
>> ---
>> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
>> change-id: 20240609-md-drivers-spmi-51a13baa2301
>
> Following up to see if anything else is needed from me. Hoping to see this in
> linux-next so I can remove it from my tracking spreadsheet :)
I still don't see this in linux-next.
Adding Greg KH since seems he's been merging this driver.
My hope is to have these warnings fixed tree-wide in 6.11.
/jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] spmi: add missing MODULE_DESCRIPTION() macros
2024-07-11 18:09 ` Jeff Johnson
@ 2024-07-17 15:23 ` Stephen Boyd
0 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2024-07-17 15:23 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jeff Johnson, Mauro Carvalho Chehab
Cc: linux-kernel, kernel-janitors
Quoting Jeff Johnson (2024-07-11 11:09:23)
>
> I still don't see this in linux-next.
> Adding Greg KH since seems he's been merging this driver.
> My hope is to have these warnings fixed tree-wide in 6.11.
I can pick it up or Greg can do so directly. I don't have anything in
the spmi queue and I was away from my computer for a few weeks so I
missed this one.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] spmi: add missing MODULE_DESCRIPTION() macros
2024-06-10 0:40 [PATCH] spmi: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-26 16:15 ` Jeff Johnson
@ 2024-07-18 21:02 ` Stephen Boyd
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2024-07-18 21:02 UTC (permalink / raw)
To: Jeff Johnson, Mauro Carvalho Chehab
Cc: linux-kernel, kernel-janitors, Jeff Johnson
Quoting Jeff Johnson (2024-06-09 17:40:17)
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/hisi-spmi-controller.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/spmi/spmi-pmic-arb.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
Applied to spmi-next
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-18 21:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-10 0:40 [PATCH] spmi: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-26 16:15 ` Jeff Johnson
2024-07-11 18:09 ` Jeff Johnson
2024-07-17 15:23 ` Stephen Boyd
2024-07-18 21:02 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®