From: Bradley Grove <bgrove@attotech.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Bradley Grove <linuxdrivers@attotech.com>,
jejb@linux.vnet.ibm.com,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: don't reinitialize adapter's req_table
Date: Thu, 25 Aug 2016 14:45:31 -0400 [thread overview]
Message-ID: <a4341156-ffcb-cacc-595e-6887ed72830c@attotech.com> (raw)
In-Reply-To: <1471747164-31441-1-git-send-email-shawn.lin@rock-chips.com>
Acked-by: Bradley Grove <bgrove@attotech.com>
On 08/20/2016 10:39 PM, Shawn Lin wrote:
> req_table is allocate by kzalloc, so we don't need to
> zero it again anyway.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/scsi/esas2r/esas2r_init.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c
> index 78ce4d61..d6e53ae 100644
> --- a/drivers/scsi/esas2r/esas2r_init.c
> +++ b/drivers/scsi/esas2r/esas2r_init.c
> @@ -963,10 +963,6 @@ bool esas2r_init_adapter_struct(struct esas2r_adapter *a,
>
> /* initialize the allocated memory */
> if (test_bit(AF_FIRST_INIT, &a->flags)) {
> - memset(a->req_table, 0,
> - (num_requests + num_ae_requests +
> - 1) * sizeof(struct esas2r_request *));
> -
> esas2r_targ_db_initialize(a);
>
> /* prime parts of the inbound list */
>
This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc. If you have reason to believe that you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or the taking of any action in reliance on the contents of this electronic transmission is strictly prohibited. If you have reason to believe that you have received this transmission in error, please notify ATTO immediately by return e-mail and delete and destroy this communication.
next prev parent reply other threads:[~2016-08-25 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 2:39 Shawn Lin
2016-08-25 18:45 ` Bradley Grove [this message]
2016-08-26 2:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4341156-ffcb-cacc-595e-6887ed72830c@attotech.com \
--to=bgrove@attotech.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxdrivers@attotech.com \
--cc=martin.petersen@oracle.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®